Issue 11234034: Crash the network process when a fatal daemon-to-network protocol error encountered.

Issue 11234034: Crash the network process when a fatal daemon-to-network protocol error encountered. (Closed)

Created:
8 years, 2 months ago by alexeypa (please no reviews)

Modified:
8 years, 2 months ago

Reviewers:
Sergey Ulanov, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Crash the network process when a fatal daemon-to-network protocol error encountered. Advantages of this approach: - We will be getting crash reports from the field when fatal mistakes happen. - The exponential backoff counter will not be reset. BUG=134694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163702

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback, #

Patch Set 3 : rebased #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -42 lines)			Patch
M	remoting/host/chromoting_messages.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	remoting/host/daemon_process.h	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	remoting/host/daemon_process.cc	View	1	4 chunks	+29 lines, -23 lines	0 comments	Download
M	remoting/host/daemon_process_unittest.cc	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	remoting/host/daemon_process_win.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	remoting/host/remoting_me2me_host.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm https://chromiumcodereview.appspot.com/11234034/diff/1/remoting/host/chromoting_messages.h File remoting/host/chromoting_messages.h (right): https://chromiumcodereview.appspot.com/11234034/diff/1/remoting/host/chromoting_messages.h#newcode17 remoting/host/chromoting_messages.h:17: // the network process misbehaves. The daemon passes ...

8 years, 2 months ago (2012-10-23 20:01:12 UTC) #3

alexeypa (please no reviews)

FYI. https://chromiumcodereview.appspot.com/11234034/diff/1/remoting/host/chromoting_messages.h File remoting/host/chromoting_messages.h (right): https://chromiumcodereview.appspot.com/11234034/diff/1/remoting/host/chromoting_messages.h#newcode17 remoting/host/chromoting_messages.h:17: // the network process misbehaves. The daemon passes ...

8 years, 2 months ago (2012-10-23 20:13:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11234034/8001

8 years, 2 months ago (2012-10-23 20:22:19 UTC) #5

Change committed as 163702

Expand Messages | Collapse Messages