Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 11234012: Updated units for operation counts. (Closed)

Created:
8 years, 2 months ago by sullivan
Modified:
8 years, 2 months ago
Reviewers:
cmp, tonyg, simonjam, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

Adds units for all Chromium perf tests. These units are recorded in the graphs.dat file, and can then be used to determine whether the test has improved or regressed when the graph goes up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163638

Patch Set 1 #

Patch Set 2 : Added other missing units #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M build/common.croc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/perf/page_cycler_test.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/test/perf/perf_test.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sullivan
Can anyone take a look at this?
8 years, 2 months ago (2012-10-22 20:39:09 UTC) #1
tonyg
lgtm
8 years, 2 months ago (2012-10-22 21:02:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/11234012/2001
8 years, 2 months ago (2012-10-22 21:08:34 UTC) #3
commit-bot: I haz the power
Presubmit check for 11234012-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-22 21:08:38 UTC) #4
sullivan
Nat, you're an OWNER in this directory, can you approve? This will allow us to ...
8 years, 2 months ago (2012-10-23 14:11:08 UTC) #5
cmp
lgtm
8 years, 2 months ago (2012-10-23 17:17:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/11234012/2001
8 years, 2 months ago (2012-10-23 17:18:21 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 19:20:43 UTC) #8
Change committed as 163638

Powered by Google App Engine
This is Rietveld 408576698