Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/test/perf/perf_test.cc

Issue 11234012: Updated units for operation counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added other missing units Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/perf/page_cycler_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/perf_test.cc
diff --git a/chrome/test/perf/perf_test.cc b/chrome/test/perf/perf_test.cc
index 1e290091cd90732ef275145deb56c48092b9141d..3423e9f375e590b504ea2f3aea4200349b9692bf 100644
--- a/chrome/test/perf/perf_test.cc
+++ b/chrome/test/perf/perf_test.cc
@@ -231,13 +231,13 @@ std::string IOPerfInfoToString(const std::string& test_name,
}
std::string t_name(test_name);
- AppendResult(output, "read_op_b", "", "r_op_b" + t_name, read_op_b, "",
+ AppendResult(output, "read_op_b", "", "r_op_b" + t_name, read_op_b, "ops",
false);
- AppendResult(output, "write_op_b", "", "w_op_b" + t_name, write_op_b, "",
+ AppendResult(output, "write_op_b", "", "w_op_b" + t_name, write_op_b, "ops",
false);
- AppendResult(output, "other_op_b", "", "o_op_b" + t_name, other_op_b, "",
+ AppendResult(output, "other_op_b", "", "o_op_b" + t_name, other_op_b, "ops",
false);
- AppendResult(output, "total_op_b", "", "IO_op_b" + t_name, total_op_b, "",
+ AppendResult(output, "total_op_b", "", "IO_op_b" + t_name, total_op_b, "ops",
false);
AppendResult(output, "read_byte_b", "", "r_b" + t_name, read_byte_b, "kb",
@@ -249,13 +249,13 @@ std::string IOPerfInfoToString(const std::string& test_name,
AppendResult(output, "total_byte_b", "", "IO_b" + t_name, total_byte_b, "kb",
false);
- AppendResult(output, "read_op_r", "", "r_op_r" + t_name, read_op_r, "",
+ AppendResult(output, "read_op_r", "", "r_op_r" + t_name, read_op_r, "ops",
false);
- AppendResult(output, "write_op_r", "", "w_op_r" + t_name, write_op_r, "",
+ AppendResult(output, "write_op_r", "", "w_op_r" + t_name, write_op_r, "ops",
false);
- AppendResult(output, "other_op_r", "", "o_op_r" + t_name, other_op_r, "",
+ AppendResult(output, "other_op_r", "", "o_op_r" + t_name, other_op_r, "ops",
false);
- AppendResult(output, "total_op_r", "", "IO_op_r" + t_name, total_op_r, "",
+ AppendResult(output, "total_op_r", "", "IO_op_r" + t_name, total_op_r, "ops",
false);
AppendResult(output, "read_byte_r", "", "r_r" + t_name, read_byte_r, "kb",
@@ -412,7 +412,7 @@ std::string MemoryUsageInfoToString(const std::string& test_name,
NOTIMPLEMENTED();
#endif
AppendResult(output, "processes", "", "proc_" + trace_name,
- chrome_processes.size(), "",
+ chrome_processes.size(), "count",
false /* not important */);
return output;
« no previous file with comments | « chrome/test/perf/page_cycler_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698