chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h - Issue 11233076: Fix spurious visibility events when committing Instant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

Issue 11233076: Fix spurious visibility events when committing Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebaseline Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

diff --git a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

index bd0c46d6cda2966ed67bc9a1f49f10c7585eb58c..d1b868cfec5d4581050b173743d7eb420e267b0c 100644

--- a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

+++ b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h

@@ -53,9 +53,9 @@ class WebContents;

// Closes the current preview and shows the active view.

- (void)hidePreview;

-// Called when a new tab with |contents| is added, so that we can check to see

-// if it's the preview being committed (and adjust internal state accordingly).

-- (void)onInsertTabWithContents:(content::WebContents*)contents;

+// Called when a tab with |contents| is activated, so that we can check to see

+// if it's the preview being activated (and adjust internal state accordingly).

+- (void)onActivateTabWithContents:(content::WebContents*)contents;

// Returns YES if the preview contents is currently showing.

- (BOOL)isShowingPreview;