Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7393)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 11233076: Fix spurious visibility events when committing Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebaseline Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 5bf5d07407aace99a8e9ce0e97008f686b7457f3..1652e0c2c6acfe5b002721280b22e7bb69542c93 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1554,13 +1554,8 @@ enum {
TabContents* tabContents = TabContents::FromWebContents(contents);
// Without the .get(), xcode fails.
[infoBarContainerController_.get() changeTabContents:tabContents];
-}
-- (void)onReplaceTabWithContents:(WebContents*)contents {
- // Simply remove the preview view if it exists; the tab strip
- // controller will reinstall the view as the active view.
- [previewableContentsController_ hidePreview];
- [self updateBookmarkBarVisibilityWithAnimation:NO];
+ [previewableContentsController_ onActivateTabWithContents:contents];
}
- (void)onTabChanged:(TabStripModelObserver::TabChangeType)change
@@ -1584,10 +1579,6 @@ enum {
[infoBarContainerController_ tabDetachedWithContents:tabContents];
}
-- (void)onInsertTabWithContents:(WebContents*)contents {
- [previewableContentsController_ onInsertTabWithContents:contents];
-}
-
- (void)userChangedTheme {
// TODO(dmaclach): Instead of redrawing the whole window, views that care
// about the active window state should be registering for notifications.
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698