Rename <browser> shim to <webview>

Rename <browser> shim to <webview>

BUG=157251
Test=WebViewTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163823

[Fady Samuel, 2012-10-23 19:27:24]

Hi Istiaque,

This CL isn't quite right, WebViewTest.Shim still fails. The size for
offsetHeight is not correct. I'm wondering if you could perhaps spot something
silly I'm doing or I forgot to do? Thanks,

Fady

[Mihai Parparita -not on Chrome, 2012-10-23 20:18:05]

On Tue, Oct 23, 2012 at 12:27 PM,  <fsamuel@chromium.org> wrote:
> This CL isn't quite right, WebViewTest.Shim still fails. The size for
> offsetHeight is not correct. I'm wondering if you could perhaps spot
> something
> silly I'm doing or I forgot to do? Thanks,

You also need to update
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/renderer/resources/...
so that <webview> gets displayed as inline-block.

Mihai

[Fady Samuel, 2012-10-23 20:25:27]

Awesome! Thanks for the drive-by Mihai! Tests are passing! Could you please
review this in full? Thanks :-)

[Mihai Parparita -not on Chrome, 2012-10-23 20:39:23]

src/chrome/common/extensions/docs/templates/articles/app_external.html should
also be updated.

http://codereview.chromium.org/11233065/diff/6001/chrome/browser_tests.isolate
File chrome/browser_tests.isolate (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/browser_tests.isolat...
chrome/browser_tests.isolate:811:
'test/data/extensions/platform_apps/web_view/',
Nit: this list appears to be sorted alphabetically.

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_renderer.gypi
File chrome/chrome_renderer.gypi (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_renderer.gypi...
chrome/chrome_renderer.gypi:155: 'renderer/resources/extensions/web_view.js',
Sorting.

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2920: 'browser/extensions/web_view_browsertest.cc',
Sorting.

http://codereview.chromium.org/11233065/diff/6001/chrome/common/extensions/pe...
File chrome/common/extensions/permissions/api_permission.cc (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/common/extensions/pe...
chrome/common/extensions/permissions/api_permission.cc:193: {
APIPermission::kWebView, "webview", kFlagCannotBeOptional },
Sorting.

http://codereview.chromium.org/11233065/diff/6001/chrome/renderer/resources/r...
File chrome/renderer/resources/renderer_resources.grd (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/renderer/resources/r...
chrome/renderer/resources/renderer_resources.grd:49: <include
name="IDR_WEB_VIEW_JS" file="extensions\web_view.js" type="BINDATA" />
Sorting.

[Fady Samuel, 2012-10-23 20:55:00]

PTAL, Mihai. Thanks.

http://codereview.chromium.org/11233065/diff/6001/chrome/browser_tests.isolate
File chrome/browser_tests.isolate (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/browser_tests.isolat...
chrome/browser_tests.isolate:811:
'test/data/extensions/platform_apps/web_view/',
On 2012/10/23 20:39:23, Mihai Parparita wrote:
> Nit: this list appears to be sorted alphabetically.

Done.

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_renderer.gypi
File chrome/chrome_renderer.gypi (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_renderer.gypi...
chrome/chrome_renderer.gypi:155: 'renderer/resources/extensions/web_view.js',
On 2012/10/23 20:39:23, Mihai Parparita wrote:
> Sorting.

Done.

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2920: 'browser/extensions/web_view_browsertest.cc',
On 2012/10/23 20:39:23, Mihai Parparita wrote:
> Sorting.

Done.

http://codereview.chromium.org/11233065/diff/6001/chrome/common/extensions/pe...
File chrome/common/extensions/permissions/api_permission.cc (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/common/extensions/pe...
chrome/common/extensions/permissions/api_permission.cc:193: {
APIPermission::kWebView, "webview", kFlagCannotBeOptional },
On 2012/10/23 20:39:23, Mihai Parparita wrote:
> Sorting.

Done.

http://codereview.chromium.org/11233065/diff/6001/chrome/renderer/resources/r...
File chrome/renderer/resources/renderer_resources.grd (right):

http://codereview.chromium.org/11233065/diff/6001/chrome/renderer/resources/r...
chrome/renderer/resources/renderer_resources.grd:49: <include
name="IDR_WEB_VIEW_JS" file="extensions\web_view.js" type="BINDATA" />
On 2012/10/23 20:39:23, Mihai Parparita wrote:
> Sorting.

Done.

[Mihai Parparita -not on Chrome, 2012-10-23 22:15:15]

LGTM

http://codereview.chromium.org/11233065/diff/2002/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/11233065/diff/2002/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:357: "extension_types":
["extension", "platform_app"]
While you're editing this file, mind removing "extension" from this list?

[Fady Samuel, 2012-10-23 23:22:07]

+sky for chrome OWNER approval. Thanks.

[sky, 2012-10-24 03:45:58]

LGTM

[commit-bot: I haz the power, 2012-10-24 04:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11233065/13001

[commit-bot: I haz the power, 2012-10-24 13:14:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11233065/13001

[commit-bot: I haz the power, 2012-10-24 14:03:22]

Change committed as 163823