Fix week_of, quarter_of, year_of calculation in my_activity.py

Fix week_of, quarter_of, year_of calculation

These calculations were not dropping the time from the provided date.
And so a week would be Monday 11AM to Monday 11AM when run at 11AM.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163360

[M-A Ruel, 2012-10-22 18:43:14]

http://codereview.chromium.org/11233041/diff/1/my_activity.py
File my_activity.py (right):

http://codereview.chromium.org/11233041/diff/1/my_activity.py#newcode151
my_activity.py:151: begin = (datetime_to_midnight(date) -
Why not date.date() or simply use datetime.date throughout?

[cjhopman, 2012-10-22 18:56:21]

http://codereview.chromium.org/11233041/diff/1/my_activity.py
File my_activity.py (right):

http://codereview.chromium.org/11233041/diff/1/my_activity.py#newcode151
my_activity.py:151: begin = (datetime_to_midnight(date) -
On 2012/10/22 18:43:14, Marc-Antoine Ruel wrote:
> Why not date.date() or simply use datetime.date throughout?

I didn't use date.date() here because later on we expect it to be a datetime,
and as far as I know doing date.date() and then converting back to datetime is
really no simpler than subtracting out the time.

I think the best thing to do would be to use datetime.date throughout and almost
made that change instead of this. Really, that is what begin/end are used as
throughout.

I sort of wanted to keep this fix simple, but if you'd rather see the change to
use datetime.date throughout I'd be happy to do that.

[M-A Ruel, 2012-10-22 19:09:08]

http://codereview.chromium.org/11233041/diff/1/my_activity.py
File my_activity.py (right):

http://codereview.chromium.org/11233041/diff/1/my_activity.py#newcode151
my_activity.py:151: begin = (datetime_to_midnight(date) -
On 2012/10/22 18:56:21, cjhopman wrote:
> On 2012/10/22 18:43:14, Marc-Antoine Ruel wrote:
> > Why not date.date() or simply use datetime.date throughout?
> 
> I didn't use date.date() here because later on we expect it to be a datetime,
> and as far as I know doing date.date() and then converting back to datetime is
> really no simpler than subtracting out the time.
> 
> I think the best thing to do would be to use datetime.date throughout and
almost
> made that change instead of this. Really, that is what begin/end are used as
> throughout.
> 
> I sort of wanted to keep this fix simple, but if you'd rather see the change
to
> use datetime.date throughout I'd be happy to do that.

I prefer simple code to simple fixes.

Also I don't see either why you are using the module relativedelta, it's easy to
do manually. That's a huge burden to ask others to install a random python
module.

Anyhow, while I wouldn't have written the code this way, I don't mind as I'm not
supporting this code anyway so lgtm.

[commit-bot: I haz the power, 2012-10-22 20:16:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11233041/1

[commit-bot: I haz the power, 2012-10-22 20:18:54]

Change committed as 163360