Fix week_of, quarter_of, year_of calculation in my_activity.py

my_activity.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Get stats about your activity.
 
 Example:
   - my_activity.py  for stats for the current week (last week on mondays).
   - my_activity.py -Q  for stats for last quarter.
@@ skipping 124 matching lines @@
       error = e
 
   raise error
 
 
 def username(email):
   """Keeps the username of an email address."""
   return email and email.split('@', 1)[0]
 
 
+def datetime_to_midnight(date):
+  return date - timedelta(hours=date.hour, minutes=date.minute,
+                          seconds=date.second, microseconds=date.microsecond)
+
+
 def get_quarter_of(date):
-  begin = date - relativedelta(months=(date.month % 3) - 1, days=(date.day - 1))
+  begin = (datetime_to_midnight(date) -

[M-A Ruel, 2012/10/22 18:43:14]

Why not date.date() or simply use datetime.date throughout?

[cjhopman, 2012/10/22 18:56:21]

I didn't use date.date() here because later on we expect it to be a datetime,
and as far as I know doing date.date() and then converting back to datetime is
really no simpler than subtracting out the time.

I think the best thing to do would be to use datetime.date throughout and almost
made that change instead of this. Really, that is what begin/end are used as
throughout.

I sort of wanted to keep this fix simple, but if you'd rather see the change to
use datetime.date throughout I'd be happy to do that.

[M-A Ruel, 2012/10/22 19:09:09]

I prefer simple code to simple fixes.

Also I don't see either why you are using the module relativedelta, it's easy to
do manually. That's a huge burden to ask others to install a random python
module.

Anyhow, while I wouldn't have written the code this way, I don't mind as I'm not
supporting this code anyway so lgtm.

+           relativedelta(months=(date.month % 3) - 1, days=(date.day - 1)))
   return begin, begin + relativedelta(months=3)
 
 
 def get_year_of(date):
-  begin = date - relativedelta(months=(date.month - 1), days=(date.day - 1))
+  begin = (datetime_to_midnight(date) -
+           relativedelta(months=(date.month - 1), days=(date.day - 1)))
   return begin, begin + relativedelta(years=1)
 
 
 def get_week_of(date):
-  begin = date - timedelta(days=date.weekday())
+  begin = (datetime_to_midnight(date) - timedelta(days=date.weekday()))
   return begin, begin + timedelta(days=7)
 
 
 def get_yes_or_no(msg):
   while True:
     response = raw_input(msg + ' yes/no [no] ')
     if response == 'y' or response == 'yes':
       return True
     elif not response or response == 'n' or response == 'no':
       return False
@@ skipping 486 matching lines @@
   print '\n\n\n'
 
   my_activity.print_changes()
   my_activity.print_reviews()
   my_activity.print_issues()
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())