Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 11233028: Handle IMR_QUERYCHARPOSITION even when there is no composition (Closed)

Created:
8 years, 2 months ago by Yohei Yukawa
Modified:
8 years, 1 month ago
Reviewers:
sky, Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Handle IMR_QUERYCHARPOSITION even when there is no composition To improve the positional accuracy of suggest UI for TSF-based IME, we'd better to handle IMR_QUERYCHARPOSITION even when there is no composition to return the caret rect. This is the same behavior of RichEdit. BUG=157101 TEST=Manually tested on Windows 7 with Baidu IME 3.0.0.44 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yohei Yukawa
8 years, 2 months ago (2012-10-22 06:49:09 UTC) #1
Seigo Nonaka
lgtm
8 years, 2 months ago (2012-10-22 06:52:18 UTC) #2
Yohei Yukawa
On 2012/10/22 06:52:18, Seigo Nonaka wrote: > lgtm Added sky@ for the owner approval.
8 years, 2 months ago (2012-10-22 06:54:21 UTC) #3
sky
LGTM
8 years, 1 month ago (2012-10-22 15:53:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/11233028/1
8 years, 1 month ago (2012-10-22 15:59:01 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-22 17:56:03 UTC) #6
Change committed as 163318

Powered by Google App Engine
This is Rietveld 408576698