tools/telemetry/telemetry/wpr_server.py - Issue 11231087: Removing flake in TemporaryHTTPServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/wpr_server.py

Issue 11231087: Removing flake in TemporaryHTTPServer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/wpr_server.py

diff --git a/tools/telemetry/telemetry/wpr_server.py b/tools/telemetry/telemetry/wpr_server.py

index 9789d959dc3551829b184a9b1a648458f69b3488..ec8dd051c737006e55d1f7339b37848510805746 100644

--- a/tools/telemetry/telemetry/wpr_server.py

+++ b/tools/telemetry/telemetry/wpr_server.py

@@ -21,8 +21,11 @@ class ReplayServer(object):

self._web_page_replay = None

self._is_record_mode = is_record_mode

+ # Note: This can cause flake if server doesn't shut down properly and keeps

+ # ports tied up. See crbug.com/157459.

self._forwarder = browser_backend.CreateForwarder(

- webpagereplay.HTTP_PORT, webpagereplay.HTTPS_PORT)

+ (webpagereplay.HTTP_PORT, webpagereplay.HTTP_PORT),

+ (webpagereplay.HTTPS_PORT, webpagereplay.HTTPS_PORT))

options = []

if self._is_record_mode:

« no previous file with comments | « tools/telemetry/telemetry/temporary_http_server.py ('k') | no next file » | no next file with comments »