tools/telemetry/telemetry/temporary_http_server.py - Issue 11231087: Removing flake in TemporaryHTTPServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/temporary_http_server.py

Issue 11231087: Removing flake in TemporaryHTTPServer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/temporary_http_server.py

diff --git a/tools/telemetry/telemetry/temporary_http_server.py b/tools/telemetry/telemetry/temporary_http_server.py

index abd7300fca4edd0df711740ed0d459b926cbee0b..f6ab8c98cadcac4a9112ec526c129bcbdad11ff8 100644

--- a/tools/telemetry/telemetry/temporary_http_server.py

+++ b/tools/telemetry/telemetry/temporary_http_server.py

@@ -31,7 +31,7 @@ class TemporaryHTTPServer(object):

cwd=self._path,

stdout=self._devnull, stderr=self._devnull)

- self._forwarder = browser_backend.CreateForwarder(self._host_port)

+ self._forwarder = browser_backend.CreateForwarder((self._host_port, None))

def IsServerUp():

return not socket.socket().connect_ex(('localhost', self._host_port))