Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/wpr_server.py

Issue 11231087: Removing flake in TemporaryHTTPServer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/wpr_server.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/wpr_server.py b/tools/chrome_remote_control/chrome_remote_control/wpr_server.py
index 1abf92792aecbbdeae91f947583a94f3ff315977..8c2bc91e2b932341ac05b205fde0bcd4477ba7e7 100644
--- a/tools/chrome_remote_control/chrome_remote_control/wpr_server.py
+++ b/tools/chrome_remote_control/chrome_remote_control/wpr_server.py
@@ -22,17 +22,19 @@ class ReplayServer(object):
self._web_page_replay = None
self._is_record_mode = is_record_mode
- self._http_forwarder = browser_backend.CreateForwarder(
- webpagereplay.HTTP_PORT)
- self._https_forwarder = browser_backend.CreateForwarder(
- webpagereplay.HTTPS_PORT)
-
options = []
if self._is_record_mode:
options.append('--record')
self._web_page_replay = webpagereplay.ReplayServer(path, options)
self._web_page_replay.StartServer()
+ self._http_forwarder = browser_backend.CreateForwarder(
nduca 2012/11/06 04:28:01 Add a // Note: This can cause flake if blahblah. S
hartmanng 2012/11/19 18:49:13 Done.
+ webpagereplay.HTTP_PORT,
+ webpagereplay.HTTP_PORT)
+ self._https_forwarder = browser_backend.CreateForwarder(
+ webpagereplay.HTTPS_PORT,
+ webpagereplay.HTTPS_PORT)
+
def __enter__(self):
return self

Powered by Google App Engine
This is Rietveld 408576698