tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py - Issue 11231087: Removing flake in TemporaryHTTPServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

Issue 11231087: Removing flake in TemporaryHTTPServer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/chrome_remote_control/chrome_remote_control/cros_interface.py ('K') | « tools/chrome_remote_control/chrome_remote_control/cros_interface.py ('k') | tools/chrome_remote_control/chrome_remote_control/wpr_server.py » ('j') | tools/chrome_remote_control/chrome_remote_control/wpr_server.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

index ce9b3595d9878d45d66c80c4960b2824a7983c0f..f23aa3c2e04106c5d085073181867f1e1efd5531 100644

--- a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

+++ b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

@@ -93,12 +93,13 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):

self._devnull.close()

self._devnull = None

- def CreateForwarder(self, host_port):

- return DoNothingForwarder(host_port)

+ def CreateForwarder(self, host_port, remote_port=None):

+ return DoNothingForwarder(host_port, remote_port)

class DoNothingForwarder(object):

- def __init__(self, host_port):

+ def __init__(self, host_port, remote_port=None):

self._host_port = host_port

+ self._remote_port = remote_port

@property

def url(self):