Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 11231086: Remove width and height property from <webview> tag. (Closed)

Created:
8 years, 2 months ago by lazyboy
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, Fady Samuel
Visibility:
Public.

Description

Remove width and height property from <webview> tag. Make the shadow <object> fill in the <webview>. This means <browser> is now supposed to be sized using style.height/style.width css. BUG=142721 TEST=content_browsertests.BrowserPluginHostTest*,BrowserPluginTest* browser_tests.WebViewTest* Updated the tests to match behavior. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163898

Patch Set 1 #

Patch Set 2 : Update the tests, less timeouts. #

Total comments: 2

Patch Set 3 : Address comments + Sync <browser> to <webview> renaming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M chrome/renderer/resources/extensions/web_view.js View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/main.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/main.js View 1 2 1 chunk +21 lines, -32 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lazyboy
Hey Mihai, We're removing the width/height property from <browser> and expect to set width/height via ...
8 years, 2 months ago (2012-10-23 21:28:21 UTC) #1
Fady Samuel
Some of these files have moved around with the <webview> change. Please update.
8 years, 1 month ago (2012-10-24 17:16:10 UTC) #2
Mihai Parparita -not on Chrome
LGTM https://chromiumcodereview.appspot.com/11231086/diff/2001/chrome/renderer/resources/extensions/browser_tag.js File chrome/renderer/resources/extensions/browser_tag.js (right): https://chromiumcodereview.appspot.com/11231086/diff/2001/chrome/renderer/resources/extensions/browser_tag.js#newcode94 chrome/renderer/resources/extensions/browser_tag.js:94: var numericValue = parseInt(value, 10); You can now ...
8 years, 1 month ago (2012-10-24 17:16:53 UTC) #3
lazyboy
Synced and updated to <webview> renaming CL. https://chromiumcodereview.appspot.com/11231086/diff/2001/chrome/renderer/resources/extensions/browser_tag.js File chrome/renderer/resources/extensions/browser_tag.js (right): https://chromiumcodereview.appspot.com/11231086/diff/2001/chrome/renderer/resources/extensions/browser_tag.js#newcode94 chrome/renderer/resources/extensions/browser_tag.js:94: var numericValue ...
8 years, 1 month ago (2012-10-24 18:29:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/11231086/7001
8 years, 1 month ago (2012-10-24 19:03:24 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-24 20:58:22 UTC) #6
Change committed as 163898

Powered by Google App Engine
This is Rietveld 408576698