Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/main.js

Issue 11231086: Remove width and height property from <webview> tag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments + Sync <browser> to <webview> renaming. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/main.js b/chrome/test/data/extensions/platform_apps/web_view/main.js
index 332202e56faee22bff65ab81b70ff0281f0bd502..b6295a866e6cab0046b498e18272febf73444ef8 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/main.js
@@ -12,41 +12,30 @@ onload = function() {
chrome.test.assertEq(300, webview.offsetWidth);
chrome.test.assertEq(200, webview.offsetHeight);
- webview.setAttribute('width', 310);
- webview.setAttribute('height', 210);
+ webview.style.width = '310px';
+ webview.style.height = '210px';
+
+ chrome.test.assertEq(310, webview.offsetWidth);
+ chrome.test.assertEq(210, webview.offsetHeight);
+
+ webview.style.width = '320px';
+ webview.style.height = '220px';
+
+ chrome.test.assertEq(320, webview.offsetWidth);
+ chrome.test.assertEq(220, webview.offsetHeight);
+
+ var dynamicWebViewTag = document.createElement('webview');
+ dynamicWebViewTag.setAttribute('src', 'data:text/html,dynamic browser');
+ dynamicWebViewTag.style.width = '330px';
+ dynamicWebViewTag.style.height = '230px';
+ document.body.appendChild(dynamicWebViewTag);
// Timeout is necessary to give the mutation observers a chance to fire.
setTimeout(function() {
- chrome.test.assertEq(310, webview.offsetWidth);
- chrome.test.assertEq(210, webview.offsetHeight);
-
- // Should also be able to query/update the dimensions via getterts/
- // setters.
- chrome.test.assertEq(310, webview.width);
- chrome.test.assertEq(210, webview.height);
-
- webview.width = 320;
- webview.height = 220;
-
- // Setters also end up operating via mutation observers.
- setTimeout(function() {
- chrome.test.assertEq(320, webview.offsetWidth);
- chrome.test.assertEq(220, webview.offsetHeight);
-
- var dynamicWebViewTag = document.createElement('webview');
- dynamicWebViewTag.setAttribute(
- 'src', 'data:text/html,dynamic browser');
- dynamicWebViewTag.setAttribute('width', '330');
- dynamicWebViewTag.setAttribute('height', '230');
- document.body.appendChild(dynamicWebViewTag);
-
- setTimeout(function() {
- chrome.test.assertEq(330, dynamicWebViewTag.offsetWidth);
- chrome.test.assertEq(230, dynamicWebViewTag.offsetHeight);
-
- chrome.test.succeed();
- }, 0);
- }, 0);
+ chrome.test.assertEq(330, dynamicWebViewTag.offsetWidth);
+ chrome.test.assertEq(230, dynamicWebViewTag.offsetHeight);
+
+ chrome.test.succeed();
}, 0);
},

Powered by Google App Engine
This is Rietveld 408576698