RLZ: remove hard-coded Win || Mac conditions.

RLZ: remove hard-coded Win || Mac conditions.

Add enable_rlz GYP variable and rely on ENABLE_RLZ macro instead of hard-coded Win || Mac checks.
Also, clean compile by gcc (signed/unsigned mismatch, etc).


BUG=157348
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164681

[Ivan Korotkov, 2012-10-25 09:32:37]

Hi Roger,

can you please take a look? I've tried to remove hard-coded assumption that RLZ
is enabled for Win || Mac only and fixed compile errors on gcc (signed/unsigned
mismatches).

I'm not sure how 'use Win inet stack' is supposed to work -- it's disabled by
default in common.gypi but enabled in rlz.gypi and causes compilation errors
(see patch set #5). Is it supported at all?

[Roger Tawa OOO till Jul 10th, 2012-10-25 14:09:41]

lgtm

Thanks for the great cleanup Ivan!  When Nico did the port to mac, he also
changed the windows implementation to use the chrome stack.  The force option
was put in there in case we had to switch back to wininet for some reason.

Nico: is that about right?

If it won't compile now, I'll take a look.  Does not affects this CL though.

[Ivan Korotkov, 2012-10-25 14:13:34]

The last patch set should compile, because trybots build Chromium, and RLZ is
disabled there :)

In patch set #5, I've temporarily enabled RLZ for Chromium -> there are compile
errors on Win because code in rlz.cc unconditionally calls
rlz_lib::SetURLRequestContext which is only defined when we use Chrome net
stack.

[Roger Tawa OOO till Jul 10th, 2012-10-25 14:25:44]

You're right, totally forgot about that :-)

[Nico, 2012-10-26 00:23:53]

On 2012/10/25 14:09:41, Roger Tawa wrote:
> lgtm
> 
> Thanks for the great cleanup Ivan!  When Nico did the port to mac, he also
> changed the windows implementation to use the chrome stack.  The force option
> was put in there in case we had to switch back to wininet for some reason.
> 
> Nico: is that about right?

Yes, that's correct.

Ivan: Please make sure that chrome/win still uses chrome's networking stack
after this.

Also, if you change rlz much, be aware of http://crbug.com/121169 -- don't rely
on that.

> 
> If it won't compile now, I'll take a look.  Does not affects this CL though.

[Ivan Korotkov, 2012-10-26 11:47:13]

> Ivan: Please make sure that chrome/win still uses chrome's networking stack
after this.

It does, since with win inet stack it doesn't seem to compile at all for me.

Ok, fingers crossed...

[commit-bot: I haz the power, 2012-10-26 11:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11226060/4006

[commit-bot: I haz the power, 2012-10-26 11:47:40]

Presubmit check for 11226060-4006 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/extensions

Presubmit checks took 1.1s to calculate.

[Ivan Korotkov, 2012-10-26 11:51:55]

Nico, I need your LGTM as well for OWNERS

[Nico, 2012-10-26 16:10:49]

lgtm

[commit-bot: I haz the power, 2012-10-26 16:29:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11226060/4006

[commit-bot: I haz the power, 2012-10-26 17:54:43]

Retried try job too often for step(s) build

[commit-bot: I haz the power, 2012-10-29 13:06:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11226060/30001

[commit-bot: I haz the power, 2012-10-29 15:41:31]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-29 17:07:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11226060/30001

[commit-bot: I haz the power, 2012-10-29 18:17:26]

Change committed as 164681