Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: build/common.gypi

Issue 11226060: RLZ: remove hard-coded Win || Mac conditions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function_registry.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 # more information and the valid --mode values. Meant to be overriden with 373 # more information and the valid --mode values. Meant to be overriden with
374 # GYP_DEFINES. 374 # GYP_DEFINES.
375 # TODO(maruel): Converted the default from 'check' to 'noop' so work can 375 # TODO(maruel): Converted the default from 'check' to 'noop' so work can
376 # be done while the builders are being reconfigured to check out test data 376 # be done while the builders are being reconfigured to check out test data
377 # files. 377 # files.
378 'test_isolation_mode%': 'noop', 378 'test_isolation_mode%': 'noop',
379 # It must not be '<(PRODUCT_DIR)' alone, the '/' is necessary otherwise 379 # It must not be '<(PRODUCT_DIR)' alone, the '/' is necessary otherwise
380 # gyp will remove duplicate flags, causing isolate.py to be confused. 380 # gyp will remove duplicate flags, causing isolate.py to be confused.
381 'test_isolation_outdir%': '<(PRODUCT_DIR)/isolate', 381 'test_isolation_outdir%': '<(PRODUCT_DIR)/isolate',
382 382
383 # Force rlz to use chrome's networking stack.
384 'force_rlz_use_chrome_net%': 1,
385
386 'sas_dll_path%': '<(DEPTH)/third_party/platformsdk_win7/files/redist/x86', 383 'sas_dll_path%': '<(DEPTH)/third_party/platformsdk_win7/files/redist/x86',
387 'wix_path%': '<(DEPTH)/third_party/wix', 384 'wix_path%': '<(DEPTH)/third_party/wix',
388 385
389 'conditions': [ 386 'conditions': [
390 # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of 387 # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of
391 # the 'conditions' clause. Initial attempts resulted in chromium and 388 # the 'conditions' clause. Initial attempts resulted in chromium and
392 # webkit disagreeing on its setting. 389 # webkit disagreeing on its setting.
393 ['OS=="mac"', { 390 ['OS=="mac"', {
394 'use_skia%': 1, 391 'use_skia%': 1,
395 }, { 392 }, {
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 'enable_background%': '<(enable_background)', 645 'enable_background%': '<(enable_background)',
649 'linux_use_gold_binary%': '<(linux_use_gold_binary)', 646 'linux_use_gold_binary%': '<(linux_use_gold_binary)',
650 'linux_use_gold_flags%': '<(linux_use_gold_flags)', 647 'linux_use_gold_flags%': '<(linux_use_gold_flags)',
651 'use_canvas_skia%': '<(use_canvas_skia)', 648 'use_canvas_skia%': '<(use_canvas_skia)',
652 'test_isolation_mode%': '<(test_isolation_mode)', 649 'test_isolation_mode%': '<(test_isolation_mode)',
653 'test_isolation_outdir%': '<(test_isolation_outdir)', 650 'test_isolation_outdir%': '<(test_isolation_outdir)',
654 'enable_automation%': '<(enable_automation)', 651 'enable_automation%': '<(enable_automation)',
655 'enable_printing%': '<(enable_printing)', 652 'enable_printing%': '<(enable_printing)',
656 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)', 653 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
657 'disable_ftp_support%': '<(disable_ftp_support)', 654 'disable_ftp_support%': '<(disable_ftp_support)',
658 'force_rlz_use_chrome_net%': '<(force_rlz_use_chrome_net)',
659 'enable_task_manager%': '<(enable_task_manager)', 655 'enable_task_manager%': '<(enable_task_manager)',
660 'sas_dll_path%': '<(sas_dll_path)', 656 'sas_dll_path%': '<(sas_dll_path)',
661 'wix_path%': '<(wix_path)', 657 'wix_path%': '<(wix_path)',
662 'android_upstream_bringup%': '<(android_upstream_bringup)', 658 'android_upstream_bringup%': '<(android_upstream_bringup)',
663 'use_libjpeg_turbo%': '<(use_libjpeg_turbo)', 659 'use_libjpeg_turbo%': '<(use_libjpeg_turbo)',
664 'use_system_libjpeg%': '<(use_system_libjpeg)', 660 'use_system_libjpeg%': '<(use_system_libjpeg)',
665 'android_build_type%': '<(android_build_type)', 661 'android_build_type%': '<(android_build_type)',
666 'use_official_google_api_keys%': '<(use_official_google_api_keys)', 662 'use_official_google_api_keys%': '<(use_official_google_api_keys)',
667 'google_api_key%': '<(google_api_key)', 663 'google_api_key%': '<(google_api_key)',
668 'google_default_client_id%': '<(google_default_client_id)', 664 'google_default_client_id%': '<(google_default_client_id)',
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 # do a developer build. 900 # do a developer build.
905 'android_app_version_name%': 'Developer Build', 901 'android_app_version_name%': 'Developer Build',
906 'android_app_version_code%': 0, 902 'android_app_version_code%': 0,
907 903
908 'sas_dll_exists': '<!(python <(DEPTH)/build/dir_exists.py <(sas_dll_path))', 904 'sas_dll_exists': '<!(python <(DEPTH)/build/dir_exists.py <(sas_dll_path))',
909 'wix_exists': '<!(python <(DEPTH)/build/dir_exists.py <(wix_path))', 905 'wix_exists': '<!(python <(DEPTH)/build/dir_exists.py <(wix_path))',
910 906
911 'windows_sdk_default_path': '<(DEPTH)/third_party/platformsdk_win8/files', 907 'windows_sdk_default_path': '<(DEPTH)/third_party/platformsdk_win8/files',
912 'directx_sdk_default_path': '<(DEPTH)/third_party/directxsdk/files', 908 'directx_sdk_default_path': '<(DEPTH)/third_party/directxsdk/files',
913 909
910 # Whether rlz is enabled.
911 'enable_rlz%': 0,
912
914 'conditions': [ 913 'conditions': [
915 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(windows_sdk_defa ult_path))"=="True"', { 914 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(windows_sdk_defa ult_path))"=="True"', {
916 'windows_sdk_path%': '<(windows_sdk_default_path)', 915 'windows_sdk_path%': '<(windows_sdk_default_path)',
917 }, { 916 }, {
918 'windows_sdk_path%': 'C:/Program Files (x86)/Windows Kits/8.0', 917 'windows_sdk_path%': 'C:/Program Files (x86)/Windows Kits/8.0',
919 }], 918 }],
920 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(directx_sdk_defa ult_path))"=="True"', { 919 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(directx_sdk_defa ult_path))"=="True"', {
921 'directx_sdk_path%': '<(directx_sdk_default_path)', 920 'directx_sdk_path%': '<(directx_sdk_default_path)',
922 }, { 921 }, {
923 'directx_sdk_path%': '$(DXSDK_DIR)', 922 'directx_sdk_path%': '$(DXSDK_DIR)',
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 # /O2 and /Ob0 (disable inline) cannot be used together because of a 1384 # /O2 and /Ob0 (disable inline) cannot be used together because of a
1386 # compiler bug, so we use /Ob1 instead. 1385 # compiler bug, so we use /Ob1 instead.
1387 'win_release_InlineFunctionExpansion': '1', 1386 'win_release_InlineFunctionExpansion': '1',
1388 'win_release_OmitFramePointers': '0', 1387 'win_release_OmitFramePointers': '0',
1389 # Ditto for debug, to support bumping win_debug_Optimization. 1388 # Ditto for debug, to support bumping win_debug_Optimization.
1390 'win_debug_InlineFunctionExpansion': 0, 1389 'win_debug_InlineFunctionExpansion': 0,
1391 'win_debug_OmitFramePointers': 0, 1390 'win_debug_OmitFramePointers': 0,
1392 # Keep the code under #ifndef NVALGRIND. 1391 # Keep the code under #ifndef NVALGRIND.
1393 'release_valgrind_build': 1, 1392 'release_valgrind_build': 1,
1394 }], 1393 }],
1394
1395 # Enable RLZ on Win and Mac.
1396 ['branding=="Chrome" and (OS=="win" or OS=="mac")', {
1397 'enable_rlz%': 1,
1398 }],
1395 ], 1399 ],
1396 1400
1397 # List of default apps to install in new profiles. The first list contains 1401 # List of default apps to install in new profiles. The first list contains
1398 # the source files as found in svn. The second list, used only for linux, 1402 # the source files as found in svn. The second list, used only for linux,
1399 # contains the destination location for each of the files. When a crx 1403 # contains the destination location for each of the files. When a crx
1400 # is added or removed from the list, the chrome/browser/resources/ 1404 # is added or removed from the list, the chrome/browser/resources/
1401 # default_apps/external_extensions.json file must also be updated. 1405 # default_apps/external_extensions.json file must also be updated.
1402 'default_apps_list': [ 1406 'default_apps_list': [
1403 'browser/resources/default_apps/external_extensions.json', 1407 'browser/resources/default_apps/external_extensions.json',
1404 'browser/resources/default_apps/gmail.crx', 1408 'browser/resources/default_apps/gmail.crx',
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1519 'xcode_settings': { 1523 'xcode_settings': {
1520 'DYLIB_INSTALL_NAME_BASE': '@rpath', 1524 'DYLIB_INSTALL_NAME_BASE': '@rpath',
1521 'LD_RUNPATH_SEARCH_PATHS': [ 1525 'LD_RUNPATH_SEARCH_PATHS': [
1522 # For unbundled binaries. 1526 # For unbundled binaries.
1523 '@loader_path/.', 1527 '@loader_path/.',
1524 # For bundled binaries, to get back from Binary.app/Contents/MacOS. 1528 # For bundled binaries, to get back from Binary.app/Contents/MacOS.
1525 '@loader_path/../../..', 1529 '@loader_path/../../..',
1526 ], 1530 ],
1527 }, 1531 },
1528 }], 1532 }],
1529 ['branding=="Chrome" and (OS=="win" or OS=="mac")', { 1533 ['enable_rlz==1', {
1530 'defines': ['ENABLE_RLZ'], 1534 'defines': ['ENABLE_RLZ'],
1531 }], 1535 }],
1532 ['component=="shared_library"', { 1536 ['component=="shared_library"', {
1533 'defines': ['COMPONENT_BUILD'], 1537 'defines': ['COMPONENT_BUILD'],
1534 }], 1538 }],
1535 ['toolkit_views==1', { 1539 ['toolkit_views==1', {
1536 'defines': ['TOOLKIT_VIEWS=1'], 1540 'defines': ['TOOLKIT_VIEWS=1'],
1537 }], 1541 }],
1538 ['ui_compositor_image_transport==1', { 1542 ['ui_compositor_image_transport==1', {
1539 'defines': ['UI_COMPOSITOR_IMAGE_TRANSPORT'], 1543 'defines': ['UI_COMPOSITOR_IMAGE_TRANSPORT'],
(...skipping 2127 matching lines...) Expand 10 before | Expand all | Expand 10 after
3667 # settings in target dicts. SYMROOT is a special case, because many other 3671 # settings in target dicts. SYMROOT is a special case, because many other
3668 # Xcode variables depend on it, including variables such as 3672 # Xcode variables depend on it, including variables such as
3669 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3673 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3670 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3674 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3671 # files to appear (when present) in the UI as actual files and not red 3675 # files to appear (when present) in the UI as actual files and not red
3672 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3676 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3673 # and therefore SYMROOT, needs to be set at the project level. 3677 # and therefore SYMROOT, needs to be set at the project level.
3674 'SYMROOT': '<(DEPTH)/xcodebuild', 3678 'SYMROOT': '<(DEPTH)/xcodebuild',
3675 }, 3679 },
3676 } 3680 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_function_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698