Add fourth batch of controlled setting indicators

Add fourth batch of controlled setting indicators

This CL continues the addition of controlled setting indicators to
the Chrome settings UI.

BUG=104955
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162995

[bartfab (slow), 2012-10-18 17:24:30]

Hi James,

Here is another controlled setting indicator for review :). This one improves
the browser test a bit as well and makes the "Set startup pages" button in the
settings UI enable/disable itself more consistently.

[bartfab (slow), 2012-10-18 17:25:01]

Oops, forgot to add reviewer.

Hi James,

Here is another controlled setting indicator for review :). This one improves
the browser test a bit as well and makes the "Set startup pages" button in the
settings UI enable/disable itself more consistently.

[James Hawkins, 2012-10-18 20:51:51]

https://codereview.chromium.org/11198065/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/11198065/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/browser_options.html:54: <span>
What is this span for?

[bartfab (slow), 2012-10-18 21:13:33]

https://codereview.chromium.org/11198065/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/11198065/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/browser_options.html:54: <span>
All settings I modified got such a <span>. It is a container for the inline
elements that should wrap together (label, controlled setting indicator,
additional controls such as extra buttons present for some settings). This
container and the input are both inline-blocks, making sure that the wrapped
elements remain strictly on one side of the <input> and do not flow around it.

[James Hawkins, 2012-10-18 21:15:16]

lgtm

[bartfab (slow), 2012-10-19 08:28:56]

Hi Joao, I just noticed I forgot to loop you in for the policy test bits.

[Joao da Silva, 2012-10-19 08:58:00]

lgtm

[commit-bot: I haz the power, 2012-10-19 12:05:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11198065/1

[commit-bot: I haz the power, 2012-10-19 13:29:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11198065/8002

[commit-bot: I haz the power, 2012-10-19 15:38:13]

Change committed as 162995