Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/policy/policy_prefs_browsertest.cc

Issue 11198065: Add fourth batch of controlled setting indicators (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed two obsoleted test cases. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/policy_prefs_browsertest.cc
diff --git a/chrome/browser/policy/policy_prefs_browsertest.cc b/chrome/browser/policy/policy_prefs_browsertest.cc
index 9e47a1da1403da0a139eb09fca97b777333ff0de..67667381b77153837ac9e5bc8c189b53db6e1562 100644
--- a/chrome/browser/policy/policy_prefs_browsertest.cc
+++ b/chrome/browser/policy/policy_prefs_browsertest.cc
@@ -382,6 +382,7 @@ void VerifyControlledSettingIndicators(Browser* browser,
EXPECT_GT(indicators->GetSize(), 0u)
<< "Expected to find at least one controlled setting indicator.";
}
+ bool have_visible_indicators = false;
for (base::ListValue::const_iterator indicator = indicators->begin();
indicator != indicators->end(); ++indicator) {
const base::DictionaryValue* properties = NULL;
@@ -399,10 +400,16 @@ void VerifyControlledSettingIndicators(Browser* browser,
EXPECT_EQ(controlled_by, indicator_controlled_by);
EXPECT_EQ(readonly, indicator_readonly);
EXPECT_TRUE(indicator_visible);
+ have_visible_indicators = true;
} else {
EXPECT_FALSE(indicator_visible);
}
}
+ if (!controlled_by.empty()) {
+ EXPECT_TRUE(have_visible_indicators)
+ << "Expected to find at least one visible controlled setting "
+ << "indicator.";
+ }
}
} // namespace
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698