 Chromium Code Reviews
 Chromium Code Reviews Issue 11198048:
  [Autofill] Update the autocomplete types implementation to match the current HTML spec.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 11198048:
  [Autofill] Update the autocomplete types implementation to match the current HTML spec.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/common/form_field_data.h | 
| diff --git a/chrome/common/form_field_data.h b/chrome/common/form_field_data.h | 
| index 286fb727293e41e575650e8d2a9cadadaccf331a..fefed050cc55c74969120d587a852bf87f2a70ad 100644 | 
| --- a/chrome/common/form_field_data.h | 
| +++ b/chrome/common/form_field_data.h | 
| @@ -27,7 +27,7 @@ struct FormFieldData { | 
| string16 name; | 
| string16 value; | 
| string16 form_control_type; | 
| - string16 autocomplete_type; | 
| + string16 autocomplete_attribute; | 
| 
Evan Stade
2012/10/19 20:36:47
why are these string16? if they're only allowed to
 
Ilya Sherman
2012/10/20 05:16:08
You're right, the only valid values for either the
 | 
| size_t max_length; | 
| bool is_autofilled; | 
| bool is_focusable; | 
| @@ -50,7 +50,7 @@ std::ostream& operator<<(std::ostream& os, const FormFieldData& field); | 
| EXPECT_EQ(expected.name, actual.name); \ | 
| EXPECT_EQ(expected.value, actual.value); \ | 
| EXPECT_EQ(expected.form_control_type, actual.form_control_type); \ | 
| - EXPECT_EQ(expected.autocomplete_type, actual.autocomplete_type); \ | 
| + EXPECT_EQ(expected.autocomplete_attribute, actual.autocomplete_attribute); \ | 
| EXPECT_EQ(expected.max_length, actual.max_length); \ | 
| EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \ | 
| } while (0) |