[Autofill] Update the autocomplete types implementation to match the current HTML spec.

chrome/common/form_field_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_FORM_FIELD_DATA_H_
 #define CHROME_COMMON_FORM_FIELD_DATA_H_
 
 #include <vector>
 
 #include "base/string16.h"
 
 // Stores information about a field in a form.
 struct FormFieldData {
   FormFieldData();
   virtual ~FormFieldData();
 
   // Equality tests for identity which does not include |value| or
   // |is_autofilled|.
   // TODO(dhollowa): These operators need to be revised when we implement field
   // ids.
   bool operator==(const FormFieldData& field) const;
   bool operator!=(const FormFieldData& field) const;
   // Comparsion operator exposed for STL map. Uses label, then name to sort.
   bool operator<(const FormFieldData& field) const;
 
   string16 label;
   string16 name;
   string16 value;
   string16 form_control_type;
-  string16 autocomplete_type;
+  string16 autocomplete_attribute;

[Evan Stade, 2012/10/19 20:36:47]

why are these string16? if they're only allowed to be ascii, they should be
std::string.

[Ilya Sherman, 2012/10/20 05:16:08]

You're right, the only valid values for either the form_control_type and the
autocomplete_attribute are ASCII, so we can use std::string.  Done.

   size_t max_length;
   bool is_autofilled;
   bool is_focusable;
   bool should_autocomplete;
 
   // For the HTML snippet |<option value="US">United States</option>|, the
   // value is "US" and the contents are "United States".
   std::vector<string16> option_values;
   std::vector<string16> option_contents;
 };
 
 // So we can compare FormFieldDatas with EXPECT_EQ().
 std::ostream& operator<<(std::ostream& os, const FormFieldData& field);
 
 // Prefer to use this macro in place of |EXPECT_EQ()| for comparing
 // |FormFieldData|s in test code.
 #define EXPECT_FORM_FIELD_DATA_EQUALS(expected, actual) \
   do { \
     EXPECT_EQ(expected.label, actual.label); \
     EXPECT_EQ(expected.name, actual.name); \
     EXPECT_EQ(expected.value, actual.value); \
     EXPECT_EQ(expected.form_control_type, actual.form_control_type); \
-    EXPECT_EQ(expected.autocomplete_type, actual.autocomplete_type); \
+    EXPECT_EQ(expected.autocomplete_attribute, actual.autocomplete_attribute); \
     EXPECT_EQ(expected.max_length, actual.max_length); \
     EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \
   } while (0)
 
 #endif  // CHROME_COMMON_FORM_FIELD_DATA_H_