Chromium Code Reviews| Index: chrome/browser/autofill/form_structure.h |
| diff --git a/chrome/browser/autofill/form_structure.h b/chrome/browser/autofill/form_structure.h |
| index fba3c1f5124b2610453bb4c8951dac659ce1336a..6a405dca685452f3dc4d4fb935ddc5ecc2272f8b 100644 |
| --- a/chrome/browser/autofill/form_structure.h |
| +++ b/chrome/browser/autofill/form_structure.h |
| @@ -154,13 +154,15 @@ class FormStructure { |
| bool EncodeFormRequest(EncodeRequestType request_type, |
| buzz::XmlElement* encompassing_xml_element) const; |
| - // Classifies each field in |fields_| based upon its |autocompletetype| |
| - // attribute, if the attribute is available. The association is stored into |
| - // |map|. Fills |found_attribute| with |true| if the attribute is available |
| - // (and non-empty) for at least one field. Fills |found_sections| with |true| |
| - // if the attribute specifies a section for at least one field. |
| - void ParseAutocompletetypeAttributes(bool* found_attribute, |
| - bool* found_sections); |
| + // Classifies each field in |fields_| based upon its |autocomplete| attribute, |
| + // if the attribute is available. The association is stored into the field's |
|
Dan Beam
2012/10/19 00:12:44
nit: I think generally I've been told to only put
Ilya Sherman
2012/10/19 04:19:32
David and I made an explicit decision to go with t
|
| + // |heuristic_type|. |
| + // Fills |found_types| with |true| if the attribute is available and neither |
| + // empty nor set to the special valeus "on" or "off" for at least one field. |
|
Dan Beam
2012/10/19 00:12:44
values
Ilya Sherman
2012/10/19 04:19:32
Done.
|
| + // Fills |found_sections| with |true| if the attribute specifies a section for |
| + // at least one field. |
| + void ParseFieldTypesFromAutocompleteAttributes(bool* found_types, |
| + bool* found_sections); |
| // Classifies each field in |fields_| into a logical section. |
| // Sections are identified by the heuristic that a logical section should not |