[Autofill] Update the autocomplete types implementation to match the current HTML spec.

chrome/browser/autofill/form_structure.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 #define CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 136 matching lines @@
   enum EncodeRequestType {
     QUERY,
     UPLOAD,
   };
 
   // Adds form info to |encompassing_xml_element|. |request_type| indicates if
   // it is a query or upload.
   bool EncodeFormRequest(EncodeRequestType request_type,
                          buzz::XmlElement* encompassing_xml_element) const;
 
-  // Classifies each field in |fields_| based upon its |autocompletetype|
-  // attribute, if the attribute is available.  The association is stored into
-  // |map|.  Fills |found_attribute| with |true| if the attribute is available
-  // (and non-empty) for at least one field.  Fills |found_sections| with |true|
-  // if the attribute specifies a section for at least one field.
-  void ParseAutocompletetypeAttributes(bool* found_attribute,
-                                       bool* found_sections);
+  // Classifies each field in |fields_| based upon its |autocomplete| attribute,
+  // if the attribute is available.  The association is stored into the field's

[Dan Beam, 2012/10/19 00:12:44]

nit: I think generally I've been told to only put 1 \s in-between sentences in
comments, though I'm not sure how consistent our code base is about this...

[Ilya Sherman, 2012/10/19 04:19:32]

David and I made an explicit decision to go with two spaces between sentences
for Autofill code.  Comments are printed in a monospaced font, so all the
arguments from typewriters still apply :)

+  // |heuristic_type|.
+  // Fills |found_types| with |true| if the attribute is available and neither
+  // empty nor set to the special valeus "on" or "off" for at least one field.

[Dan Beam, 2012/10/19 00:12:44]

values

[Ilya Sherman, 2012/10/19 04:19:32]

Done.

+  // Fills |found_sections| with |true| if the attribute specifies a section for
+  // at least one field.
+  void ParseFieldTypesFromAutocompleteAttributes(bool* found_types,
+                                                 bool* found_sections);
 
   // Classifies each field in |fields_| into a logical section.
   // Sections are identified by the heuristic that a logical section should not
   // include multiple fields of the same autofill type (with some exceptions, as
   // described in the implementation).  Sections are furthermore distinguished
   // as either credit card or non-credit card sections.
   // If |has_author_specified_sections| is true, only the second pass --
   // distinguishing credit card sections from non-credit card ones -- is made.
   void IdentifySections(bool has_author_specified_sections);
 
@@ skipping 29 matching lines @@
   RequestMethod method_;
 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_