Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 11198008: [Mac] Tweak crash logging for -sendEvent: crash. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
Reviewers:
Robert Sesek, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Tweak crash logging for -sendEvent: crash. https://chromiumcodereview.appspot.com/11140040 adds the event's -description as a breakpad key. Unfortunately, event type 28, which is undocumented, is sent by Mountain Lion when you do a control-scroll zoom. Work around it manually. BUG=154483, 156103 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162397

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 9 (0 generated)
Scott Hess - ex-Googler
I had hoped to delete this code, but I haven't found any (relevant) crashes with ...
8 years, 2 months ago (2012-10-16 21:56:32 UTC) #1
Robert Sesek
lovez it lgtm
8 years, 2 months ago (2012-10-16 21:58:05 UTC) #2
Scott Hess - ex-Googler
No balk from rsesek, so maybe OWNERS LGTM from thakis?
8 years, 2 months ago (2012-10-16 22:20:40 UTC) #3
Nico
lgtm https://codereview.chromium.org/11198008/diff/1/chrome/browser/chrome_browser_application_mac.mm File chrome/browser/chrome_browser_application_mac.mm (right): https://codereview.chromium.org/11198008/diff/1/chrome/browser/chrome_browser_application_mac.mm#newcode441 chrome/browser/chrome_browser_application_mac.mm:441: base::mac::ScopedCrashKey key(kSendEventKey, value); On 2012/10/16 21:56:32, shess wrote: ...
8 years, 2 months ago (2012-10-16 22:23:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11198008/1
8 years, 2 months ago (2012-10-16 22:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11198008/1
8 years, 2 months ago (2012-10-17 11:20:10 UTC) #6
commit-bot: I haz the power
Change committed as 162397
8 years, 2 months ago (2012-10-17 14:17:12 UTC) #7
Scott Hess - ex-Googler
On 2012/10/16 22:35:38, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 2 months ago (2012-10-17 14:55:06 UTC) #8
Nico
8 years, 2 months ago (2012-10-17 17:29:37 UTC) #9
On 2012/10/17 14:55:06, shess wrote:
> On 2012/10/16 22:35:38, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/shess%2540chromium.org/11198008/1
> 
> On 2012/10/17 11:20:10, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/shess%2540chromium.org/11198008/1
> 
> Well, I guess that missed the canary, then.

Urgent crashfix CLs should probably not be landed through the cq, for this
reason.

Powered by Google App Engine
This is Rietveld 408576698