Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 11140040: [Mac] Additional crash logging for -sendEvent: crash. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
Reviewers:
Robert Sesek, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Additional crash logging for -sendEvent: crash. -[NSEvent description] is what gdb's po command would print against the event. It is basically an ASCII serialization of the event. BUG=154483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Scott Hess - ex-Googler
I was implementing away, then realized that basically I was re-implementing this but most likely ...
8 years, 2 months ago (2012-10-15 22:06:00 UTC) #1
Robert Sesek
What's the average length on these descriptions? IIRC NSEvent's is pretty long. Will it fit ...
8 years, 2 months ago (2012-10-15 22:07:22 UTC) #2
Scott Hess - ex-Googler
On 2012/10/15 22:07:22, rsesek wrote: > What's the average length on these descriptions? IIRC NSEvent's ...
8 years, 2 months ago (2012-10-15 22:14:41 UTC) #3
Robert Sesek
LGTM
8 years, 2 months ago (2012-10-15 22:17:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11140040/1
8 years, 2 months ago (2012-10-15 23:48:31 UTC) #5
commit-bot: I haz the power
Presubmit check for 11140040-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-15 23:48:36 UTC) #6
Scott Hess - ex-Googler
On 2012/10/15 23:48:36, I haz the power (commit-bot) wrote: > ** Presubmit ERRORS ** > ...
8 years, 2 months ago (2012-10-15 23:50:26 UTC) #7
Nico
Your enthusiasm for my return lgtm
8 years, 2 months ago (2012-10-15 23:52:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11140040/1
8 years, 2 months ago (2012-10-15 23:54:23 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 02:50:09 UTC) #10
Change committed as 162054

Powered by Google App Engine
This is Rietveld 408576698