Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 11196036: Finish conversion from bloom filter to prefix set in safe browsing. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Finish conversion from bloom filter to prefix set in safe browsing. Always use the prefix set, delete any old bloom filter. Users who haven't launched since M-22 (so more than six weeks) will run without protection until first update. BUG=71832 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162949

Patch Set 1 #

Patch Set 2 : Delete the unnecessary unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -615 lines) Patch
M chrome/PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/safe_browsing/bloom_filter.h View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/safe_browsing/bloom_filter.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/safe_browsing/bloom_filter_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.h View 6 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 13 chunks +14 lines, -81 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 3 chunks +2 lines, -58 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Scott Hess - ex-Googler
In M-23 SB2.FilterLoad records which filter was loaded at startup. PREFIX_SET is at 98.7% on ...
8 years, 2 months ago (2012-10-18 03:16:45 UTC) #1
ramant (doing other things)
sorry for the delay. LGTM
8 years, 2 months ago (2012-10-19 03:50:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11196036/5001
8 years, 2 months ago (2012-10-19 04:50:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 11196036-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-19 04:51:01 UTC) #4
Scott Hess - ex-Googler
On 2012/10/19 03:50:38, ramant wrote: > sorry for the delay. > > LGTM np, definitely ...
8 years, 2 months ago (2012-10-19 04:51:09 UTC) #5
Scott Hess - ex-Googler
On 2012/10/19 04:51:01, I haz the power (commit-bot) wrote: > Presubmit check for 11196036-5001 failed ...
8 years, 2 months ago (2012-10-19 05:01:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11196036/5001
8 years, 2 months ago (2012-10-19 05:02:02 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 06:28:22 UTC) #8
Change committed as 162949

Powered by Google App Engine
This is Rietveld 408576698