Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 11196016: [Android WebView] Fix some findbugs warnings. (Closed)

Created:
8 years, 2 months ago by benm (inactive)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Fix some findbugs warnings. M D DLS: Dead store to imageUrl in org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testCalledForImage() At AwContentsClientShouldInterceptRequestTest.java M D DLS: Dead store to onPageFinishedCallCount in org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testOnLoadResourceCalledWithCorrectUrl() At AwContentsClientShouldInterceptRequestTest.java M D SF: Switch statement found in org.chromium.android_webview.AwContents$IoThreadClientHandler.handleMessage(Message) where default case is missing At AwContents.java M P SIC: Should org.chromium.android_webview.test.AwContentsClientShouldIgnoreNavigationTest$TestAwContentsClient$ShouldIgnoreNavigationHelper be a _static_ inner class? At AwContentsClientShouldIgnoreNavigationTest.java Java only change and android bots are happy. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162360

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
benm (inactive)
ptal
8 years, 2 months ago (2012-10-17 10:54:09 UTC) #1
mkosiba (inactive)
lgtm
8 years, 2 months ago (2012-10-17 12:13:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/11196016/1
8 years, 2 months ago (2012-10-17 12:17:50 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 12:18:04 UTC) #4
Change committed as 162360

Powered by Google App Engine
This is Rietveld 408576698