android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java - Issue 11196016: [Android WebView] Fix some findbugs warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

Issue 11196016: [Android WebView] Fix some findbugs warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

index f5b454687dbc77aa3712b4c5cca340808984b9d6..44c264641260b97d881b89626dc363ff8e5415bd 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

@@ -168,7 +168,6 @@ public class AwContentsClientShouldInterceptRequestTest extends AndroidWebViewTe

final String aboutPageUrl = addAboutPageToTestServer(mWebServer);

int callCount = onLoadResourceHelper.getCallCount();

- int onPageFinishedCallCount = contentsClient.getOnPageFinishedHelper().getCallCount();

loadUrlAsync(awContents, aboutPageUrl);

@@ -269,7 +268,7 @@ public class AwContentsClientShouldInterceptRequestTest extends AndroidWebViewTe

contentsClient.getShouldInterceptRequestHelper();

final String imagePath = "/" + CommonResources.FAVICON_FILENAME;

- final String imageUrl = mWebServer.setResponseBase64(imagePath,

+ mWebServer.setResponseBase64(imagePath,

CommonResources.FAVICON_DATA_BASE64, CommonResources.getImagePngHeaders(true));

final String pageWithImage =

addPageToTestServer(mWebServer, "/page_with_image.html",