Improve codec tests to test a broader variety of dimensions.

Improve codec tests to test a broader variety of dimensions.

BUG=147522
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163679

[Wez, 2012-10-19 05:47:18]

simonmorris: PTAL
sergeyu: This change makes the verbatim encoder unit-tests for small buffer
sizes rather slow.

[simonmorris, 2012-10-19 15:48:07]

lgtm with optional suggestion.

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (right):

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:360: int kSizes[] = {320, 319, 317, 240, 160};
int -> const int ?

[Sergey Ulanov, 2012-10-19 17:50:26]

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (right):

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:370: for (size_t yi = 0; yi < arraysize(kSizes);
++yi) {
whoa, it's 25 tests total. How much time does it take to run this test now? If
it is too slow now then maybe it's better to vary only one dimension while
keeping other one fixed. That will be only 10 size combinations and about the
same coverage.

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:373: PrepareEncodeData(size,
media::VideoFrame::RGB32, &memory);
style police: 4 spaces indent here please.

[Wez, 2012-10-19 20:56:53]

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (right):

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:360: int kSizes[] = {320, 319, 317, 240, 160};
On 2012/10/19 15:48:08, simonmorris wrote:
> int -> const int ?

Done.

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:370: for (size_t yi = 0; yi < arraysize(kSizes);
++yi) {
On 2012/10/19 17:50:26, sergeyu wrote:
> whoa, it's 25 tests total. How much time does it take to run this test now? If
> it is too slow now then maybe it's better to vary only one dimension while
> keeping other one fixed. That will be only 10 size combinations and about the
> same coverage.

I've reduced it to sixteen sizes; I want to test frames that are much wider than
they are high, and vice-versa, and also frames with width or height that is
non-zero mod 2 and 4.

http://codereview.chromium.org/11195062/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:373: PrepareEncodeData(size,
media::VideoFrame::RGB32, &memory);
On 2012/10/19 17:50:26, sergeyu wrote:
> style police: 4 spaces indent here please.

Done.

[commit-bot: I haz the power, 2012-10-19 20:59:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11195062/8001

[commit-bot: I haz the power, 2012-10-19 21:30:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-19 21:33:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11195062/8001

[commit-bot: I haz the power, 2012-10-19 21:40:22]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-23 20:08:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11195062/8001

[commit-bot: I haz the power, 2012-10-23 21:20:06]

Change committed as 163679