Issue 11194004: Remove unused methods from WebContentsDelegate, WebContentsDelegateAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194004: Remove unused methods from WebContentsDelegate, WebContentsDelegateAndroid (Closed)

Created:
8 years, 2 months ago by John Knottenbelt

Modified:
8 years, 2 months ago

Reviewers:
joth, mkosiba (inactive), Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused methods from WebContentsDelegate, WebContentsDelegateAndroid ShouldOverrideLoading and ShouldIgnoreNavigation was upstreamed for Chrome on Android to implement the URL overriding feature, however, we are planning to implement this in a different way (by means of network request throttle). BUG=156044 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162396

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -58 lines)			Patch
M	chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.cc	View	2 chunks	+0 lines, -39 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm (and OWNER approve for chrome/browser/component/web_contents_delegate_android/)

8 years, 2 months ago (2012-10-16 18:34:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11194004/1

8 years, 2 months ago (2012-10-16 20:24:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11194004/1

8 years, 2 months ago (2012-10-17 11:19:04 UTC) #5

Change committed as 162396

Expand Messages | Collapse Messages