Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h

Issue 11194004: Remove unused methods from WebContentsDelegate, WebContentsDelegateAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h
diff --git a/chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h b/chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h
index 3c57dba79782208c3dad6c0998d7f36e4597da71..069aef7d733905d858ddca712e2bf4bc9df2728b 100644
--- a/chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h
+++ b/chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h
@@ -58,14 +58,6 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {
content::WebContents* source,
const content::OpenURLParams& params) OVERRIDE;
- // Don't merge back.
- // TODO(mkosiba): Upstream base class's implementaion of this method.
- virtual bool ShouldIgnoreNavigation(
- content::WebContents* source,
- const GURL& url,
- const content::Referrer& referrer,
- WindowOpenDisposition disposition,
- content::PageTransition transition_type);
virtual void NavigationStateChanged(const content::WebContents* source,
unsigned changed_flags) OVERRIDE;
virtual void AddNewContents(content::WebContents* source,
@@ -93,7 +85,6 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {
virtual void UpdateTargetURL(content::WebContents* source,
int32 page_id,
const GURL& url) OVERRIDE;
- virtual bool ShouldOverrideLoading(const GURL& url) OVERRIDE;
virtual void HandleKeyboardEvent(
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698