Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11193011: New angular 'getting started' tutorial. (Closed)

Created:
8 years, 2 months ago by mkearney1
Modified:
8 years, 1 month ago
Reviewers:
ericbidelman, mkearney
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

New angular 'getting started' tutorial. This was written by Eric Bidelman in a doc; I've put it into html. I've expanded the MVC chapter so the tutorials are exposed; I've also included links in the MVC architecture doc to the tutorials. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166229

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 27

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+773 lines, -0 lines) Patch
A chrome/common/extensions/docs/static/images/csperrors.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/customframe.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/fetchedicon.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/fileicons.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/listoffiles.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/noframe.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/uploader.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/static/images/writecompleted.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/angular_framework.html View 1 2 3 4 5 6 7 8 9 1 chunk +771 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_frameworks.html View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/apps_sidenav.html View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/angular_framework.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ericbidelman
https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html File chrome/common/extensions/docs/templates/articles/angular_framework.html (right): https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode79 chrome/common/extensions/docs/templates/articles/angular_framework.html:79: A stripped down version of the Uploader's manifest like ...
8 years, 1 month ago (2012-10-30 18:56:52 UTC) #1
mkearney
Just one action item I'm not sure about. https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html File chrome/common/extensions/docs/templates/articles/angular_framework.html (right): https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode79 chrome/common/extensions/docs/templates/articles/angular_framework.html:79: A ...
8 years, 1 month ago (2012-11-06 00:46:11 UTC) #2
ericbidelman
What is the AI you're not sure of? I think I'm missing it. On 2012/11/06 ...
8 years, 1 month ago (2012-11-06 00:57:36 UTC) #3
mkearney
You were asking if one of the items should be a <li>, and I replied ...
8 years, 1 month ago (2012-11-06 15:40:50 UTC) #4
ericbidelman
lgtm
8 years, 1 month ago (2012-11-06 16:55:10 UTC) #5
ericbidelman
8 years, 1 month ago (2012-11-06 16:55:15 UTC) #6 
Ah, got it.


On Tue, Nov 6, 2012 at 7:40 AM, Meggin Kearney <mkearney@google.com> wrote:

> You were asking if one of the items should be a <li>, and I replied with a
> comment-- leaving the doc as is. Make sense?
>
> Meggin
>
>
> On Mon, Nov 5, 2012 at 4:57 PM, <ericbidelman@chromium.org> wrote:
>
>> What is the AI you're not sure of? I think I'm missing it.
>>
>>
>> On 2012/11/06 00:46:11, mkearney wrote:
>>
>>> Just one action item I'm not sure about.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html>
>>
>>> File chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html
>>> (right):
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode79<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode79>
>>
>>>
chrome/common/extensions/docs/**templates/articles/angular_**framework.html:79:
>>> A
>>> stripped down version of the Uploader's manifest like this:
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > looks like
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode177<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode177>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:177:
>>>
>> The
>>
>>> Uploader uses frame: 'none' to render the window as a "blank slate"
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>frame: 'none'</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode253<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode253>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:253:
>>> stamp out an &lt;li> for every doc in our data model "docs".
>>> Yes. I had to use &lt; in place of literal <.
>>>
>>
>>  On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > Should this be a list?
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode261<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode261>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:261:
>>> we're using data-* attributes for Angular's
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>data-*</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode271<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode271>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:271:
>>> directive to tell the DocsController to have reign over the template
>>> <body>:
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>DocsController</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode279<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode279>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:279:
>>> &lt;img src="&#123;{doc.icon}&#125;"> &lt;a
>>> href="&#123;{doc.**alternateLink}&#125;">&#123;{**
>>> doc.title}&#125;&lt;/a>
>>> &#123;{doc.size}&#125;
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > src= -> data-ng-src=
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode290<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode290>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:290:
>>> Angular is going to do that heavy lifting for us!
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > is doing that heavy lifting...
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode333<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode333>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:333:
>>> &lt;img src=<strong>"&#123;{doc.icon}&**#125;"</strong>> &lt;a
>>>
>>
>> href=<strong>"&#123;{doc.**alternateLink}&#125;"</strong>**
>> ><strong>&#123;{doc.title}&#**125;</strong>&lt;/a>
>>
>>>   <strong>&#123;{doc.size}&#125;**</strong>
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > src -> data-ng-src
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode509<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode509>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:509:
>>> <code>fetchDocs()</code> uses Angular's $http service
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>$http</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode511<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode511>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:511:
>>>
>> The
>>
>>> oauth access token is included in the Authorization header
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>Authorization</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode516<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode516>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:516:
>>>
>> The
>>
>>> successCallback processes the API response and
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > <code>successCallback</code>
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode709<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode709>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:709:
>>>
>> the
>>
>>> icons won't be in the HTML5 filesystem and the calls to
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > Filesystem
>>>
>>
>>  Done.
>>>
>>
>>
>> https://chromiumcodereview.**appspot.com/11193011/diff/**
>> 10013/chrome/common/**extensions/docs/templates/**
>>
articles/angular_framework.**html#newcode743<https://chromiumcodereview.appspot.com/11193011/diff/10013/chrome/common/extensions/docs/templates/articles/angular_framework.html#newcode743>
>>
>>> chrome/common/extensions/docs/**templates/articles/angular_**
>>> framework.html:743:
>>> handles this feature by implemenuing a small library
>>> On 2012/10/30 18:56:52, ericbidelman wrote:
>>> > implementing
>>>
>>
>>  Done.
>>>
>>
>>
>>
>>
https://chromiumcodereview.**appspot.com/11193011/<https://chromiumcodereview...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698