Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 11193002: Add third batch of controlled setting indicators (Closed)

Created:
8 years, 2 months ago by bartfab (slow)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add third batch of controlled setting indicators This CL continues the addition of controlled setting indicators to the Chrome settings UI. It also refactors the policy_prefs_browsertest and its test cases definition file so that a single policy mapping to multiple prefs can be tested. BUG=104955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162975

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add a space between neighboring braces for legibility. #

Patch Set 3 : Comments addressed. #

Total comments: 2

Patch Set 4 : Comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1177 lines, -738 lines) Patch
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 2 12 chunks +264 lines, -201 lines 0 comments Download
M chrome/browser/resources/options/browser_options.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 5 chunks +64 lines, -28 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +840 lines, -509 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bartfab (slow)
Hi James, could you review the UI side please? Hi Joao, could you review the ...
8 years, 2 months ago (2012-10-16 16:33:18 UTC) #1
Joao da Silva
policy/ changes lgtm. Please see comments inline. https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/policy_prefs_browsertest.cc File chrome/browser/policy/policy_prefs_browsertest.cc (right): https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/policy_prefs_browsertest.cc#newcode285 chrome/browser/policy/policy_prefs_browsertest.cc:285: continue; add ...
8 years, 2 months ago (2012-10-16 17:58:41 UTC) #2
bartfab (slow)
https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/policy_prefs_browsertest.cc File chrome/browser/policy/policy_prefs_browsertest.cc (right): https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/policy_prefs_browsertest.cc#newcode285 chrome/browser/policy/policy_prefs_browsertest.cc:285: continue; On 2012/10/16 17:58:41, Joao da Silva wrote: > ...
8 years, 2 months ago (2012-10-16 20:50:30 UTC) #3
James Hawkins
https://chromiumcodereview.appspot.com/11193002/diff/2007/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://chromiumcodereview.appspot.com/11193002/diff/2007/chrome/browser/resources/options/browser_options.html#newcode263 chrome/browser/resources/options/browser_options.html:263: <span i18n-content="safeBrowsingEnableProtection"></span> Just set the i18n-content of the label ...
8 years, 2 months ago (2012-10-17 03:29:28 UTC) #4
bartfab (slow)
https://codereview.chromium.org/11193002/diff/2007/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/11193002/diff/2007/chrome/browser/resources/options/browser_options.html#newcode263 chrome/browser/resources/options/browser_options.html:263: <span i18n-content="safeBrowsingEnableProtection"></span> On 2012/10/17 03:29:28, James Hawkins wrote: > ...
8 years, 2 months ago (2012-10-18 13:05:04 UTC) #5
James Hawkins
lgtm
8 years, 2 months ago (2012-10-18 16:34:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11193002/10001
8 years, 2 months ago (2012-10-19 07:54:49 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 09:51:31 UTC) #8
Change committed as 162975

Powered by Google App Engine
This is Rietveld 408576698