sync: Remove UpdateProgress and related code

sync: Remove UpdateProgress and related code

Following the merge of the process updates and verify updates step,
there is no longer any need for the UpdateProgress class.  Its only use
outside of tests was to pass data between the verify and update steps
during a sync cycle.

The class had some use in tests, but most of the assertions based on it
were somewhat redundant.  They can be replaced by assertions on similar,
but non-ModelSafe, counts.

BUG=156238
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162576

[rlarocque, 2012-10-17 00:00:56]

This patch should not affect program behaviour in any way.

Please review.

[tim (not reviewing), 2012-10-17 00:16:07]

On 2012/10/17 00:00:56, rlarocque wrote:
> This patch should not affect program behaviour in any way.
> 
> Please review.

As I was mentioning in previous UpdateProgress-ectomy code reviews, I'm
concerned that removing this class altogether moves us further away from fixing
crbug.com/121521.  It's hard to make an argument to keep unused code, but at the
same time I was working on a patch to silo state early on in the session and
stash it in the UpdateProgress for easy access later by process + apply, but I
haven't had the time to finish it, and it's probably not quite right now. See
http://codereview.chromium.org/9950137 

Since this appears to be something you need for your goal, maybe you can look at
addressing it?  That patch does the collecting in Process, but maybe it needs to
be done during download?

[akalin, 2012-10-17 20:36:26]

It sounds like I don't need to look at this until that other patch is done?

[rlarocque, 2012-10-17 20:59:54]

On 2012/10/17 20:36:26, akalin wrote:
> It sounds like I don't need to look at this until that other patch is done?

I just resolved this with Tim over IM.  The review can move forward as is.

[akalin, 2012-10-17 21:18:14]

lgtm!

[commit-bot: I haz the power, 2012-10-17 21:21:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11190013/2001

[commit-bot: I haz the power, 2012-10-17 22:00:08]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-17 22:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11190013/2001

[commit-bot: I haz the power, 2012-10-17 23:58:45]

Change committed as 162576