Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: sync/sessions/status_controller_unittest.cc

Issue 11190013: sync: Remove UpdateProgress and related code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting improvements Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/status_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/status_controller_unittest.cc
diff --git a/sync/sessions/status_controller_unittest.cc b/sync/sessions/status_controller_unittest.cc
index 619e1fae34cdb0c9bdf018d10b6a890528315db3..3e5143bfb647ee27d4fba71bd41546def9d1ee8d 100644
--- a/sync/sessions/status_controller_unittest.cc
+++ b/sync/sessions/status_controller_unittest.cc
@@ -45,37 +45,22 @@ TEST_F(StatusControllerTest, ReadYourWrites) {
TEST_F(StatusControllerTest, HasConflictingUpdates) {
StatusController status(routes_);
EXPECT_FALSE(status.HasConflictingUpdates());
+
{
ScopedModelSafeGroupRestriction r(&status, GROUP_UI);
- EXPECT_FALSE(status.update_progress());
- status.mutable_update_progress()->AddAppliedUpdate(SUCCESS,
- syncable::Id());
- status.mutable_update_progress()->AddAppliedUpdate(CONFLICT_SIMPLE,
- syncable::Id());
- EXPECT_TRUE(status.update_progress()->HasConflictingUpdates());
+ status.increment_num_updates_applied();
+ status.mutable_simple_conflict_ids()->insert(syncable::Id());
}
EXPECT_TRUE(status.HasConflictingUpdates());
-
- {
- ScopedModelSafeGroupRestriction r(&status, GROUP_PASSIVE);
- EXPECT_FALSE(status.update_progress());
- }
}
TEST_F(StatusControllerTest, HasConflictingUpdates_NonBlockingUpdates) {
StatusController status(routes_);
EXPECT_FALSE(status.HasConflictingUpdates());
- {
- ScopedModelSafeGroupRestriction r(&status, GROUP_UI);
- EXPECT_FALSE(status.update_progress());
- status.mutable_update_progress()->AddAppliedUpdate(SUCCESS,
- syncable::Id());
- status.mutable_update_progress()->AddAppliedUpdate(CONFLICT_HIERARCHY,
- syncable::Id());
- EXPECT_TRUE(status.update_progress()->HasConflictingUpdates());
- }
+ status.increment_num_updates_applied();
+ status.increment_num_encryption_conflicts();
EXPECT_TRUE(status.HasConflictingUpdates());
}
@@ -116,9 +101,6 @@ TEST_F(StatusControllerTest, TotalNumConflictingItems) {
// Basic test that non group-restricted state accessors don't cause violations.
TEST_F(StatusControllerTest, Unrestricted) {
StatusController status(routes_);
- const UpdateProgress* progress =
- status.GetUnrestrictedUpdateProgress(GROUP_UI);
- EXPECT_FALSE(progress);
status.model_neutral_state();
status.download_updates_succeeded();
status.ServerSaysNothingMoreToDownload();
« no previous file with comments | « sync/sessions/status_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698