Skip Unacceptable Items in new Autofill UI when Navigating with Keys.

chrome/browser/autofill/autofill_popup_view.cc

Index: chrome/browser/autofill/autofill_popup_view.cc
diff --git a/chrome/browser/autofill/autofill_popup_view.cc b/chrome/browser/autofill/autofill_popup_view.cc
index 0ca2bd4d2cbeb07afdb259da6b41c1adb99fb149..11763f521c0ba1e12cdf6cb94470574b3e661a4d 100644
--- a/chrome/browser/autofill/autofill_popup_view.cc
+++ b/chrome/browser/autofill/autofill_popup_view.cc
@@ -136,6 +136,10 @@ void AutofillPopupView::ClearSelectedLine() {
 void AutofillPopupView::SelectNextLine() {
   int new_selected_line = selected_line_ + 1;
 
+  while (static_cast<size_t>(new_selected_line) < autofill_values_.size() &&

[Ilya Sherman, 2012/10/20 03:38:24]

nit: Please add a comment describing this block.

[csharp, 2012/10/22 13:29:20]

Done.

+         !CanAccept(autofill_unique_ids()[new_selected_line]))

[Ilya Sherman, 2012/10/20 03:38:24]

Optional nit: I prefer to always include curly braces for loops, but I think
it's optional in the style guide.

[csharp, 2012/10/22 13:29:20]

Done.

+    ++new_selected_line;
+
   if (new_selected_line == static_cast<int>(autofill_values_.size()))
     new_selected_line = 0;
 
@@ -145,6 +149,10 @@ void AutofillPopupView::SelectNextLine() {
 void AutofillPopupView::SelectPreviousLine() {
   int new_selected_line = selected_line_ - 1;
 
+  while (kNoSelection < new_selected_line &&

[Ilya Sherman, 2012/10/20 03:38:24]

Optional nit: I think this would be slightly clearer as "while (new_selected_lin
> kNoSelection ..."

[csharp, 2012/10/22 13:29:20]

Done.

+         !CanAccept(autofill_unique_ids()[new_selected_line]))
+    --new_selected_line;

[Ilya Sherman, 2012/10/20 03:38:24]

nit: Ditto on both counts.

[csharp, 2012/10/22 13:29:20]

Done.

+
   if (new_selected_line <= kNoSelection)
     new_selected_line = autofill_values_.size() - 1;