Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 11189093: Skip Unacceptable Items in new Autofill UI when Navigating with Keys. (Closed)

Created:
8 years, 2 months ago by csharp
Modified:
8 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, browser-components-watch_chromium.org, dyu1
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Skip Unacceptable Items in new Autofill UI when Navigating with Keys. When navigating with keys now skip over the unselectable items that are just added for UI reasons (currently this is just the separator). R=isherman@chromium.org BUG=51644 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163291

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/browser/autofill/autofill_popup_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_popup_view.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csharp
8 years, 2 months ago (2012-10-19 17:16:37 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autofill_popup_view.cc File chrome/browser/autofill/autofill_popup_view.cc (right): https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autofill_popup_view.cc#newcode139 chrome/browser/autofill/autofill_popup_view.cc:139: while (static_cast<size_t>(new_selected_line) < autofill_values_.size() && nit: Please add ...
8 years, 2 months ago (2012-10-20 03:38:24 UTC) #2
csharp
https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofill/autofill_popup_view.cc File chrome/browser/autofill/autofill_popup_view.cc (right): https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofill/autofill_popup_view.cc#newcode139 chrome/browser/autofill/autofill_popup_view.cc:139: while (static_cast<size_t>(new_selected_line) < autofill_values_.size() && On 2012/10/20 03:38:24, Ilya ...
8 years, 2 months ago (2012-10-22 13:29:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/11189093/5001
8 years, 2 months ago (2012-10-22 13:29:37 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 15:25:24 UTC) #5
Change committed as 163291

Powered by Google App Engine
This is Rietveld 408576698