Skip Unacceptable Items in new Autofill UI when Navigating with Keys.

Skip Unacceptable Items in new Autofill UI when Navigating with Keys.

When navigating with keys now skip over the unselectable items that are just added for UI reasons (currently this is just the separator).

R=isherman@chromium.org
BUG=51644
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163291

[Ilya Sherman, 2012-10-20 03:38:24]

LGTM

https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autof...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_popup_view.cc:139: while
(static_cast<size_t>(new_selected_line) < autofill_values_.size() &&
nit: Please add a comment describing this block.

https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_popup_view.cc:140:
!CanAccept(autofill_unique_ids()[new_selected_line]))
Optional nit: I prefer to always include curly braces for loops, but I think
it's optional in the style guide.

https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_popup_view.cc:152: while (kNoSelection <
new_selected_line &&
Optional nit: I think this would be slightly clearer as "while (new_selected_lin
> kNoSelection ..."

https://codereview.chromium.org/11189093/diff/1/chrome/browser/autofill/autof...
chrome/browser/autofill/autofill_popup_view.cc:154: --new_selected_line;
nit: Ditto on both counts.

[csharp, 2012-10-22 13:29:20]

https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofil...
File chrome/browser/autofill/autofill_popup_view.cc (right):

https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofil...
chrome/browser/autofill/autofill_popup_view.cc:139: while
(static_cast<size_t>(new_selected_line) < autofill_values_.size() &&
On 2012/10/20 03:38:24, Ilya Sherman wrote:
> nit: Please add a comment describing this block.

Done.

https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofil...
chrome/browser/autofill/autofill_popup_view.cc:140:
!CanAccept(autofill_unique_ids()[new_selected_line]))
On 2012/10/20 03:38:24, Ilya Sherman wrote:
> Optional nit: I prefer to always include curly braces for loops, but I think
> it's optional in the style guide.

Done.

https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofil...
chrome/browser/autofill/autofill_popup_view.cc:152: while (kNoSelection <
new_selected_line &&
On 2012/10/20 03:38:24, Ilya Sherman wrote:
> Optional nit: I think this would be slightly clearer as "while
(new_selected_lin
> > kNoSelection ..."

Done.

https://chromiumcodereview.appspot.com/11189093/diff/1/chrome/browser/autofil...
chrome/browser/autofill/autofill_popup_view.cc:154: --new_selected_line;
On 2012/10/20 03:38:24, Ilya Sherman wrote:
> nit: Ditto on both counts.

Done.

[commit-bot: I haz the power, 2012-10-22 13:29:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/11189093/5001

[commit-bot: I haz the power, 2012-10-22 15:25:24]

Change committed as 163291