Skip Unacceptable Items in new Autofill UI when Navigating with Keys.

chrome/browser/autofill/autofill_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_popup_view.h"
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_external_delegate.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 118 matching lines @@
   }
 }
 
 void AutofillPopupView::ClearSelectedLine() {
   SetSelectedLine(kNoSelection);
 }
 
 void AutofillPopupView::SelectNextLine() {
   int new_selected_line = selected_line_ + 1;
 
+  while (static_cast<size_t>(new_selected_line) < autofill_values_.size() &&

[Ilya Sherman, 2012/10/20 03:38:24]

nit: Please add a comment describing this block.

[csharp, 2012/10/22 13:29:20]

Done.

+         !CanAccept(autofill_unique_ids()[new_selected_line]))

[Ilya Sherman, 2012/10/20 03:38:24]

Optional nit: I prefer to always include curly braces for loops, but I think
it's optional in the style guide.

[csharp, 2012/10/22 13:29:20]

Done.

+    ++new_selected_line;
+
   if (new_selected_line == static_cast<int>(autofill_values_.size()))
     new_selected_line = 0;
 
   SetSelectedLine(new_selected_line);
 }
 
 void AutofillPopupView::SelectPreviousLine() {
   int new_selected_line = selected_line_ - 1;
 
+  while (kNoSelection < new_selected_line &&

[Ilya Sherman, 2012/10/20 03:38:24]

Optional nit: I think this would be slightly clearer as "while (new_selected_lin
> kNoSelection ..."

[csharp, 2012/10/22 13:29:20]

Done.

+         !CanAccept(autofill_unique_ids()[new_selected_line]))
+    --new_selected_line;

[Ilya Sherman, 2012/10/20 03:38:24]

nit: Ditto on both counts.

[csharp, 2012/10/22 13:29:20]

Done.

+
   if (new_selected_line <= kNoSelection)
     new_selected_line = autofill_values_.size() - 1;
 
   SetSelectedLine(new_selected_line);
 }
 
 bool AutofillPopupView::AcceptSelectedLine() {
   if (selected_line_ == kNoSelection)
     return false;
 
@@ skipping 162 matching lines @@
 void AutofillPopupView::Observe(int type,
                                 const content::NotificationSource& source,
                                 const content::NotificationDetails& details) {
   if (type == content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED) {
     if (!*content::Details<bool>(details).ptr())
       Hide();
   } else if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) {
     Hide();
   }
 }