Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 11188072: Minor style cleanup of QuicProtocol (Closed)

Created:
8 years, 2 months ago by Ryan Hamilton
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Minor style cleanup of QuicProtocol Merge internal change 35543340 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163321

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again #

Patch Set 5 : export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -34 lines) Patch
M net/quic/quic_protocol.h View 1 2 3 4 3 chunks +5 lines, -34 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 2 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ryan Hamilton
8 years, 2 months ago (2012-10-18 23:46:56 UTC) #1
jar (doing other things)
Please upstream nit... LGTM https://codereview.chromium.org/11188072/diff/1/net/quic/quic_protocol.h File net/quic/quic_protocol.h (right): https://codereview.chromium.org/11188072/diff/1/net/quic/quic_protocol.h#newcode9 net/quic/quic_protocol.h:9: #include <limits> nit: alphabetize
8 years, 2 months ago (2012-10-19 00:26:53 UTC) #2
Ryan Hamilton
Thanks https://codereview.chromium.org/11188072/diff/1/net/quic/quic_protocol.h File net/quic/quic_protocol.h (right): https://codereview.chromium.org/11188072/diff/1/net/quic/quic_protocol.h#newcode9 net/quic/quic_protocol.h:9: #include <limits> On 2012/10/19 00:26:53, jar wrote: > ...
8 years, 2 months ago (2012-10-21 22:09:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11188072/5001
8 years, 2 months ago (2012-10-21 22:09:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11188072/6003
8 years, 2 months ago (2012-10-22 03:03:11 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-22 03:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11188072/18001
8 years, 2 months ago (2012-10-22 04:09:39 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-22 04:27:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11188072/18001
8 years, 2 months ago (2012-10-22 13:50:05 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-22 14:00:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11188072/9006
8 years, 2 months ago (2012-10-22 16:07:12 UTC) #11
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 18:17:05 UTC) #12
Change committed as 163321

Powered by Google App Engine
This is Rietveld 408576698