Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: net/quic/quic_protocol.h

Issue 11188072: Minor style cleanup of QuicProtocol (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: export Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index 30d681618090df1f790628e02e70db6afa7a1106..04cd091150c4d2486df7b023ec5d6250d432c92e 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -6,6 +6,7 @@
#define NET_QUIC_QUIC_PROTOCOL_H_
#include <limits>
+#include <ostream>
#include <utility>
#include <vector>
@@ -248,30 +249,12 @@ struct NET_EXPORT_PRIVATE QuicAckFrame {
congestion_info.type = kNone;
}
+ NET_EXPORT_PRIVATE friend std::ostream& operator<<(std::ostream& os,
+ const QuicAckFrame& s);
+
SentPacketInfo sent_info;
ReceivedPacketInfo received_info;
CongestionInfo congestion_info;
-
- friend std::ostream& operator<<(std::ostream& os, const QuicAckFrame& s) {
- os << "largest_received: " << s.received_info.largest_received
- << " time: " << s.received_info.time_received
- << " missing: ";
- for (base::hash_set<QuicPacketSequenceNumber>::const_iterator it =
- s.received_info.missing_packets.begin();
- it != s.received_info.missing_packets.end(); ++it) {
- os << *it << " ";
- }
-
- os << " least_waiting: " << s.sent_info.least_unacked
- << " no_retransmit: ";
- for (base::hash_set<QuicPacketSequenceNumber>::const_iterator it =
- s.sent_info.non_retransmiting.begin();
- it != s.sent_info.non_retransmiting.end(); ++it) {
- os << *it << " ";
- }
- os << "\n";
- return os;
- }
};
struct NET_EXPORT_PRIVATE QuicRstStreamFrame {
@@ -329,19 +312,7 @@ struct NET_EXPORT_PRIVATE QuicFecData {
// The last protected packet's sequence number will be one
// less than the sequence number of the FEC packet.
base::StringPiece redundancy;
- bool operator==(const QuicFecData& other) const {
- if (fec_group != other.fec_group) {
- return false;
- }
- if (first_protected_packet_sequence_number !=
- other.first_protected_packet_sequence_number) {
- return false;
- }
- if (redundancy != other.redundancy) {
- return false;
- }
- return true;
- }
+ bool operator==(const QuicFecData& other) const;
};
struct NET_EXPORT_PRIVATE QuicPacketData {
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698