Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 11188044: change inline function optimization from /Ob0 to /Ob1. xref http://code.google.com/p/drmemory/issue… (Closed)

Created:
8 years, 2 months ago by zhaoqin
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

change inline function optimization from /Ob0 to /Ob1 for build_for_tool=drmemory. xref http://code.google.com/p/drmemory/issues/detail?id=1054 R=bruening@chromium.org BUG=DrM-i#1054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162712

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/common.gypi View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zhaoqin
8 years, 2 months ago (2012-10-17 19:57:55 UTC) #1
Derek Bruening
LGTM if the comment is updated. suggestion: I'd also preface the commit message with "for ...
8 years, 2 months ago (2012-10-18 04:11:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-10-18 13:45:14 UTC) #3
Reid Kleckner
LGTM Let's see if this works.
8 years, 2 months ago (2012-10-18 13:51:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/11188044/1002
8 years, 2 months ago (2012-10-18 13:51:24 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 15:45:17 UTC) #6
Change committed as 162712

Powered by Google App Engine
This is Rietveld 408576698