build/common.gypi - Issue 11188044: change inline function optimization from /Ob0 to /Ob1. xref http://code.google.com/p/drmemory/issue…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 11188044: change inline function optimization from /Ob0 to /Ob1. xref http://code.google.com/p/drmemory/issue… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update comment Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 22b570b5ed14d1e85f70c2d5b91aaab91e49eafb..f66a62a866d8814a4df41989637f3d41441dd123 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1374,7 +1374,10 @@

# Iterator debugging is slow.

'win_debug_disable_iterator_debugging': '1',

# Try to disable optimizations that mess up stacks in a release build.

- 'win_release_InlineFunctionExpansion': '0',

+ # DrM-i#1054 (http://code.google.com/p/drmemory/issues/detail?id=1054)

+ # /O2 and /Ob0 (disable inline) cannot be used together because of a

+ # compiler bug, so we use /Ob1 instead.

+ 'win_release_InlineFunctionExpansion': '1',

'win_release_OmitFramePointers': '0',

# Ditto for debug, to support bumping win_debug_Optimization.

'win_debug_InlineFunctionExpansion': 0,

« no previous file with comments | « no previous file | no next file » | no next file with comments »