Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11185069: Remove redundant option from script. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 2 months ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove redundant option from script. gyp files using sdk-build were already cleaned up, it is now safe to remove this option. Cleanup in chromium here: https://chromiumcodereview.appspot.com/11066094 Cleanup in webkit here: http://trac.webkit.org/changeset/131681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M testing/android/generate_native_test.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shashi
8 years, 2 months ago (2012-10-19 00:09:51 UTC) #1
cjhopman
lgtm
8 years, 2 months ago (2012-10-19 00:12:25 UTC) #2
Isaac (away)
lgtm
8 years, 2 months ago (2012-10-19 00:20:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11185069/1
8 years, 2 months ago (2012-10-19 00:22:34 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 03:35:04 UTC) #5 
Change committed as 162915

Powered by Google App Engine
This is Rietveld 408576698