Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 11066094: Nuke unused test code. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 2 months ago
Reviewers:
Yaron, nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Nuke unused test code. SDK build is the default build, we do not need Android.mk based compilation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161127

Patch Set 1 #

Total comments: 2

Patch Set 2 : nuke more test code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -35 lines) Patch
M build/all_android.gyp View 1 2 chunks +2 lines, -12 lines 0 comments Download
M build/apk_test.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/generate_native_test.py View 1 3 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shashi
8 years, 2 months ago (2012-10-10 01:38:04 UTC) #1
Yaron
https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py File testing/android/generate_native_test.py (right): https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py#newcode211 testing/android/generate_native_test.py:211: if options.sdk_build: Just remove the sdk_build option entirely
8 years, 2 months ago (2012-10-10 01:51:33 UTC) #2
shashi
https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py File testing/android/generate_native_test.py (right): https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py#newcode211 testing/android/generate_native_test.py:211: if options.sdk_build: On 2012/10/10 01:51:33, Yaron wrote: > Just ...
8 years, 2 months ago (2012-10-10 03:41:11 UTC) #3
Yaron
On 2012/10/10 03:41:11, shashi wrote: > https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py > File testing/android/generate_native_test.py (right): > > https://codereview.chromium.org/11066094/diff/1/testing/android/generate_native_test.py#newcode211 > ...
8 years, 2 months ago (2012-10-10 15:41:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11066094/6003
8 years, 2 months ago (2012-10-10 15:42:20 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 17:21:10 UTC) #6
Change committed as 161127

Powered by Google App Engine
This is Rietveld 408576698