Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 11174006: Implement ScopedTestNSSDB instead of OpenTestNSSDB() (Closed)

Created:
8 years, 2 months ago by Takashi Toyoshima
Modified:
8 years, 2 months ago
Reviewers:
satorux1, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reland: Implement ScopedTestNSSDB instead of OpenTestNSSDB() This CL needs memory suppression because of missing CloseTestNSSDB(). See also TODO. BUG=136950, 156433 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162327 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162659

Patch Set 1 #

Patch Set 2 : try #

Patch Set 3 : fix CrOS test #

Patch Set 4 : fix another test #

Total comments: 15

Patch Set 5 : reflect the 1st review #

Patch Set 6 : Oops, define CRYPTO_EXPORT_PRIVATE #

Patch Set 7 : reland with suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -42 lines) Patch
M chrome/browser/chromeos/cros/network_library_unittest.cc View 1 2 3 4 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser_unittest.cc View 1 2 3 4 2 chunks +3 lines, -12 lines 0 comments Download
M crypto/crypto_export.h View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M crypto/nss_util.h View 1 2 3 4 1 chunk +15 lines, -5 lines 0 comments Download
M crypto/nss_util.cc View 1 2 3 4 5 6 1 chunk +8 lines, -2 lines 0 comments Download
M net/base/nss_cert_database_unittest.cc View 1 2 3 4 2 chunks +3 lines, -11 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Hi Ryan, Could you take a look?
8 years, 2 months ago (2012-10-16 12:44:56 UTC) #1
Ryan Sleevi
LGTM, mod nits. Thanks for doing this! https://codereview.chromium.org/11174006/diff/1008/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc File chrome/browser/chromeos/cros/onc_network_parser_unittest.cc (right): https://codereview.chromium.org/11174006/diff/1008/chrome/browser/chromeos/cros/onc_network_parser_unittest.cc#newcode132 chrome/browser/chromeos/cros/onc_network_parser_unittest.cc:132: scoped_ptr<crypto::ScopedTestNSSDB> test_nssdb_; ...
8 years, 2 months ago (2012-10-16 18:19:02 UTC) #2
Takashi Toyoshima
Thanks. I revised my CL for landing. I added satorux for chrome/browser/chromeos/cros . Hi Satoru, ...
8 years, 2 months ago (2012-10-17 04:58:53 UTC) #3
satorux1
chromeos LGTM. Looks awesome.
8 years, 2 months ago (2012-10-17 06:13:23 UTC) #4
Takashi Toyoshima
Thank you, Satoru.
8 years, 2 months ago (2012-10-17 06:37:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11174006/20001
8 years, 2 months ago (2012-10-17 06:40:40 UTC) #6
commit-bot: I haz the power
Change committed as 162327
8 years, 2 months ago (2012-10-17 08:35:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/11174006/14006
8 years, 2 months ago (2012-10-18 03:52:19 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-18 07:02:57 UTC) #9
Change committed as 162659

Powered by Google App Engine
This is Rietveld 408576698