Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/chromeos/cros/network_library_unittest.cc

Issue 11174006: Implement ScopedTestNSSDB instead of OpenTestNSSDB() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reland with suppression Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/onc_network_parser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library_unittest.cc
diff --git a/chrome/browser/chromeos/cros/network_library_unittest.cc b/chrome/browser/chromeos/cros/network_library_unittest.cc
index 751e22cb3ea820efc8f7ae5a146d31b273d9f918..47b81fcd972d45db42d3573db89b22d65d0e7719 100644
--- a/chrome/browser/chromeos/cros/network_library_unittest.cc
+++ b/chrome/browser/chromeos/cros/network_library_unittest.cc
@@ -138,20 +138,10 @@ class NetworkLibraryStubTest : public testing::Test {
public:
NetworkLibraryStubTest() : cros_(NULL) {}
- static void SetUpTestCase() {
- // Ideally, we'd open a test DB for each test case, and close it
- // again, removing the temp dir, but unfortunately, there's a
- // bug in NSS that prevents this from working, so we just open
- // it once, and empty it for each test case. Here's the bug:
- // https://bugzilla.mozilla.org/show_bug.cgi?id=588269
- ASSERT_TRUE(crypto::OpenTestNSSDB());
- // There is no matching TearDownTestCase call to close the test NSS DB
- // because that would leave NSS in a potentially broken state for further
- // tests, due to https://bugzilla.mozilla.org/show_bug.cgi?id=588269
- }
-
protected:
virtual void SetUp() {
+ ASSERT_TRUE(test_nssdb_.is_open());
+
slot_ = net::NSSCertDatabase::GetInstance()->GetPublicModule();
cros_ = CrosLibrary::Get()->GetNetworkLibrary();
ASSERT_TRUE(cros_) << "GetNetworkLibrary() Failed!";
@@ -207,6 +197,7 @@ class NetworkLibraryStubTest : public testing::Test {
}
scoped_refptr<net::CryptoModule> slot_;
+ crypto::ScopedTestNSSDB test_nssdb_;
};
// Default stub state:
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros/onc_network_parser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698