Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1116583002: Add connection breakage. (Closed)

Created:
5 years, 7 months ago by ghost stip (do not use)
Modified:
5 years, 7 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address maruel's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M infra/libs/buildbot/master.py View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/libs/buildbot/test/master_test.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
ghost stip (do not use)
ptal
5 years, 7 months ago (2015-04-29 02:54:09 UTC) #2
M-A Ruel
lgtm with fix https://chromiumcodereview.appspot.com/1116583002/diff/1/infra/libs/buildbot/master.py File infra/libs/buildbot/master.py (right): https://chromiumcodereview.appspot.com/1116583002/diff/1/infra/libs/buildbot/master.py#newcode144 infra/libs/buildbot/master.py:144: except requests.exceptions.Timeout: except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
5 years, 7 months ago (2015-04-29 17:25:07 UTC) #4
ghost stip (do not use)
https://codereview.chromium.org/1116583002/diff/1/infra/libs/buildbot/master.py File infra/libs/buildbot/master.py (right): https://codereview.chromium.org/1116583002/diff/1/infra/libs/buildbot/master.py#newcode144 infra/libs/buildbot/master.py:144: except requests.exceptions.Timeout: On 2015/04/29 17:25:07, M-A Ruel wrote: > ...
5 years, 7 months ago (2015-04-29 20:48:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116583002/20001
5 years, 7 months ago (2015-04-29 20:49:33 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 20:54:09 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/d164879eb40273a5ed3393aded843...

Powered by Google App Engine
This is Rietveld 408576698