Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1116003002: [DevTools] Simplify getting back to default network order. (Closed)

Created:
5 years, 7 months ago by dgozman
Modified:
5 years, 7 months ago
Reviewers:
paulirish, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Simplify getting back to default network order. Column header "Timeline" in NetworkPanel is actually a combo-box. This is a very confusing UI. In this patch combobox and all related code is eliminated. BUG=462189 Original patch by eustas@chromium.org. https://codereview.chromium.org/1048823002/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -275 lines) Patch
M Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 14 chunks +12 lines, -136 lines 0 comments Download
M Source/devtools/front_end/network/NetworkOverview.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/NetworkTimeCalculator.js View 8 chunks +9 lines, -116 lines 0 comments Download
M Source/devtools/front_end/network/networkLogView.css View 1 chunk +1 line, -9 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/DataGrid.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Take a look please.
5 years, 7 months ago (2015-04-30 11:20:02 UTC) #2
dgozman
Ping. +Paul, do you think that removing this functionality is a good idea?
5 years, 7 months ago (2015-05-13 01:17:09 UTC) #4
pfeldman
On 2015/05/13 01:17:09, dgozman_ooo wrote: > Ping. +Paul, do you think that removing this functionality ...
5 years, 7 months ago (2015-05-15 23:40:10 UTC) #5
dgozman
On 2015/05/15 23:40:10, pfeldman_slow wrote: > On 2015/05/13 01:17:09, dgozman_ooo wrote: > > Ping. +Paul, ...
5 years, 7 months ago (2015-05-16 01:37:04 UTC) #6
pfeldman
I have no problem with the bug, it is just your implementation that is regressing ...
5 years, 7 months ago (2015-05-16 13:41:23 UTC) #7
paulirish
5 years, 7 months ago (2015-05-16 23:47:17 UTC) #8
On 2015/05/13 at 01:17:09, dgozman wrote:
> Ping. +Paul, do you think that removing this functionality is a good idea?


I've never liked the combo box that's completely hidden. 
But I've also encountered the bug in https://crbug.com/462189

Since this becomes more about UX let's pick it up the discussion there.

Powered by Google App Engine
This is Rietveld 408576698