Issue 11145006: PlatformAppApiTest class should not enable experimental APIs by default

Issue 11145006: PlatformAppApiTest class should not enable experimental APIs by default (Closed)

Created:
8 years, 2 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 2 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PlatformAppApiTest class should not enable experimental APIs by default Now that some of our APIs are out of experimental, the ones still in experimental should append the command line individually in their tests as needed. BUG=155430 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162004

Patch Set 1 #

Patch Set 2 : fixed missing include #

Total comments: 1

Patch Set 3 : fix typo #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -31 lines)			Patch
M	chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/dns/dns_apitest.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/notification/notification_apitest.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_apitest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/socket/socket_apitest.cc	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_apitest.h	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_apitest.cc	View	1 2	2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

miket_OOO

lgtm http://codereview.chromium.org/11145006/diff/8001/chrome/browser/extensions/api/socket/socket_apitest.cc File chrome/browser/extensions/api/socket/socket_apitest.cc (right): http://codereview.chromium.org/11145006/diff/8001/chrome/browser/extensions/api/socket/socket_apitest.cc#newcode38 chrome/browser/extensions/api/socket/socket_apitest.cc:38: // enable-experimental-extension-apis flag. After that we should remote ...

8 years, 2 months ago (2012-10-15 21:38:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/11145006/16003

8 years, 2 months ago (2012-10-15 21:43:59 UTC) #3

Change committed as 162004

Expand Messages | Collapse Messages