Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 11145006: PlatformAppApiTest class should not enable experimental APIs by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix typo Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/stringprintf.h" 6 #include "base/stringprintf.h"
7 #include "chrome/browser/extensions/api/dns/host_resolver_wrapper.h" 7 #include "chrome/browser/extensions/api/dns/host_resolver_wrapper.h"
8 #include "chrome/browser/extensions/api/dns/mock_host_resolver_creator.h" 8 #include "chrome/browser/extensions/api/dns/mock_host_resolver_creator.h"
9 #include "chrome/browser/extensions/api/socket/socket_api.h" 9 #include "chrome/browser/extensions/api/socket/socket_api.h"
10 #include "chrome/browser/extensions/extension_apitest.h" 10 #include "chrome/browser/extensions/extension_apitest.h"
11 #include "chrome/browser/extensions/extension_function_test_utils.h" 11 #include "chrome/browser/extensions/extension_function_test_utils.h"
12 #include "chrome/browser/extensions/extension_service.h" 12 #include "chrome/browser/extensions/extension_service.h"
13 #include "chrome/browser/extensions/extension_test_message_listener.h" 13 #include "chrome/browser/extensions/extension_test_message_listener.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/common/chrome_switches.h"
15 #include "chrome/test/base/in_process_browser_test.h" 16 #include "chrome/test/base/in_process_browser_test.h"
16 #include "chrome/test/base/ui_test_utils.h" 17 #include "chrome/test/base/ui_test_utils.h"
17 #include "net/base/mock_host_resolver.h" 18 #include "net/base/mock_host_resolver.h"
18 #include "net/test/test_server.h" 19 #include "net/test/test_server.h"
19 20
20 using extensions::Extension; 21 using extensions::Extension;
21 22
22 namespace utils = extension_function_test_utils; 23 namespace utils = extension_function_test_utils;
23 24
24 namespace { 25 namespace {
25 26
26 const std::string kHostname = "127.0.0.1"; 27 const std::string kHostname = "127.0.0.1";
27 const int kPort = 8888; 28 const int kPort = 8888;
28 29
29 class SocketApiTest : public PlatformAppApiTest { 30 class SocketApiTest : public ExtensionApiTest {
30 public: 31 public:
31 SocketApiTest() : resolver_event_(true, false), 32 SocketApiTest() : resolver_event_(true, false),
32 resolver_creator_( 33 resolver_creator_(
33 new extensions::MockHostResolverCreator()) { 34 new extensions::MockHostResolverCreator()) {
34 } 35 }
35 36
37 // We need this while the socket.{listen,accept} methods require the
38 // enable-experimental-extension-apis flag. After that we should remove it,
39 // as well as the "experimental" permission in the test apps' manifests.
40 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
41 ExtensionApiTest::SetUpCommandLine(command_line);
42 command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
43 }
44
36 void SetUpOnMainThread() OVERRIDE { 45 void SetUpOnMainThread() OVERRIDE {
37 extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting( 46 extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting(
38 resolver_creator_->CreateMockHostResolver()); 47 resolver_creator_->CreateMockHostResolver());
39 } 48 }
40 49
41 void CleanUpOnMainThread() OVERRIDE { 50 void CleanUpOnMainThread() OVERRIDE {
42 extensions::HostResolverWrapper::GetInstance()-> 51 extensions::HostResolverWrapper::GetInstance()->
43 SetHostResolverForTesting(NULL); 52 SetHostResolverForTesting(NULL);
44 resolver_creator_->DeleteMockHostResolver(); 53 resolver_creator_->DeleteMockHostResolver();
45 } 54 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 EXPECT_TRUE(listener.WaitUntilSatisfied()); 196 EXPECT_TRUE(listener.WaitUntilSatisfied());
188 listener.Reply("go"); 197 listener.Reply("go");
189 198
190 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 199 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
191 } 200 }
192 201
193 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerUnbindOnUnload) { 202 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerUnbindOnUnload) {
194 ASSERT_TRUE(RunExtensionTest("socket/unload")) << message_; 203 ASSERT_TRUE(RunExtensionTest("socket/unload")) << message_;
195 ASSERT_TRUE(RunExtensionTest("socket/unload")) << message_; 204 ASSERT_TRUE(RunExtensionTest("socket/unload")) << message_;
196 } 205 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/serial/serial_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698